Page MenuHomeFreeBSD
Differential D36534

qcom_tlmm: fix compiler errors, return error code
ClosedPublic
Actions

Authored by adrian on Sep 12 2022, 6:37 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 16, 6:22 PM
Unknown Object (File)
Wed, Sep 16, 6:09 PM
Unknown Object (File)
Wed, Sep 16, 2:50 PM
Unknown Object (File)
Fri, Sep 11, 4:10 AM
Unknown Object (File)
Sun, Sep 6, 2:42 AM
Unknown Object (File)
Sat, Sep 5, 11:02 PM
Unknown Object (File)
Sat, Sep 5, 8:03 PM
Unknown Object (File)
Sat, Sep 5, 5:04 PM
View All Files
Subscribers
imp

Details

Reviewers
imp
Commits
rG82302a49fde3: qcom_tlmm: use return code instead of always returning true.
Summary

This was failing due to unused return values; so just use them.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47347
Build 44234: arc lint + arc unit

Event Timeline

adrian created this revision.Sep 12 2022, 6:37 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 12 2022, 6:37 AM
adrian requested review of this revision.Sep 12 2022, 6:37 AM
Harbormaster completed remote builds in B47336: Diff 110459.Sep 12 2022, 6:37 AM
adrian added a parent revision: D36533: qcom_clk: compilation fixes.Sep 12 2022, 6:37 AM
adrian added a child revision: D36535: qcom_qup: compilation fixes.
imp added a comment.Sep 12 2022, 1:25 PM

This is more of a 'return the return value that the compiler found I wasn't using' which is a bit different than the dead code stuff.

adrian updated this revision to Diff 110474.Sep 12 2022, 6:31 PM

update

Harbormaster completed remote builds in B47347: Diff 110474.Sep 12 2022, 6:31 PM
imp accepted this revision.Sep 12 2022, 6:35 PM
This revision is now accepted and ready to land.Sep 12 2022, 6:35 PM
Closed by commit rG82302a49fde3: qcom_tlmm: use return code instead of always returning true. (authored by adrian). · Explain WhySep 13 2022, 3:11 AM
This revision was automatically updated to reflect the committed changes.
adrian added a commit: rG82302a49fde3: qcom_tlmm: use return code instead of always returning true..

Revision Contents
Changeset List

PathSize
sys/
dev/
qcom_tlmm/
6 lines

Diff 110474

View Options

sys/dev/qcom_tlmm/qcom_tlmm_pin.c

Loading...