Differential D36532

ipq4018: fix USB ehci/xhci bus glue to compile again
ClosedPublic
Actions

Authored by adrian on Sep 12 2022, 6:37 AM.

Details

Reviewers

imp

Commits

rGf060362adeb4: ipq4018: remove write-only variables in USB ehci/xhci bus glue

Summary

Changes in compilers / warnings/errors caused this to stop compiling.
Delete the dead code.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Sep 12 2022, 6:37 AM

Herald added subscribers: andrew, imp. · View Herald TranscriptSep 12 2022, 6:37 AM

adrian requested review of this revision.Sep 12 2022, 6:37 AM

Harbormaster completed remote builds in B47334: Diff 110457.Sep 12 2022, 6:37 AM

adrian added a parent revision: D36531: qcom_gcc: fix the parent clock to work again.Sep 12 2022, 6:37 AM

adrian added a child revision: D36533: qcom_clk: compilation fixes.

I'd suggest changing the title to 'remove write-only variables' or something similar. Tell what was done to make it compile.

update

Harbormaster completed remote builds in B47345: Diff 110472.Sep 12 2022, 6:31 PM

imp accepted this revision.Sep 12 2022, 6:34 PM

This revision is now accepted and ready to land.Sep 12 2022, 6:34 PM

Closed by commit rGf060362adeb4: ipq4018: remove write-only variables in USB ehci/xhci bus glue (authored by adrian). · Explain WhySep 13 2022, 3:11 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rGf060362adeb4: ipq4018: remove write-only variables in USB ehci/xhci bus glue.

Revision Contents
Changeset List

Path

Size

sys/

arm/

qualcomm/

ipq4018_usb_hs_phy.c

2 lines

ipq4018_usb_ss_phy.c

2 lines

Diff 110493

View Options

sys/arm/qualcomm/ipq4018_usb_hs_phy.c