Differential D36533

qcom_clk: compilation fixes
ClosedPublic
Actions

Authored by adrian on Sep 12 2022, 6:37 AM.

Tags

None

Referenced Files

	F156762661: D36533.id.diff
	Sat, May 16, 4:03 AM

	Unknown Object (File)
	Wed, May 13, 5:05 PM

	Unknown Object (File)
	Wed, May 13, 5:05 PM

	Unknown Object (File)
	Wed, May 13, 5:05 PM

	Unknown Object (File)
	Wed, May 13, 5:05 PM

	Unknown Object (File)
	Wed, May 13, 5:05 PM

	Unknown Object (File)
	Wed, May 13, 4:54 PM

	Unknown Object (File)
	Fri, May 8, 11:21 AM

Subscribers

Details

Reviewers

Commits

rG3d9bd8252205: qcom_clk: compilation fixes

Summary

remove dead code
log the enabled state if debugging is enabled

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adrian created this revision.Sep 12 2022, 6:37 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 12 2022, 6:37 AM

adrian requested review of this revision.Sep 12 2022, 6:37 AM

Harbormaster completed remote builds in B47335: Diff 110458.Sep 12 2022, 6:37 AM

adrian added a parent revision: D36532: ipq4018: fix USB ehci/xhci bus glue to compile again.Sep 12 2022, 6:37 AM

adrian added a child revision: D36534: qcom_tlmm: fix compiler errors, return error code.

imp added inline comments.Sep 12 2022, 1:24 PM

sys/dev/qcom_clk/qcom_clk_rcg2.c
268	bool enabled __unused; is how this case is more often handled. If the ifdef above were under INVARIANTS, then __diagunused would be used instead. But this is more of a debug than a diagnostic and we don't have a good define for those.

update

Harbormaster completed remote builds in B47346: Diff 110473.Sep 12 2022, 6:31 PM

imp accepted this revision.Sep 12 2022, 6:35 PM

This revision is now accepted and ready to land.Sep 12 2022, 6:35 PM

Closed by commit rG3d9bd8252205: qcom_clk: compilation fixes (authored by adrian). · Explain WhySep 13 2022, 3:11 AM

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG3d9bd8252205: qcom_clk: compilation fixes.

Revision Contents
Changeset List

Path

Size

sys/

dev/

qcom_clk/

qcom_clk_apssdiv.c

3 lines

qcom_clk_rcg2.c

8 lines

Diff 110494

sys/dev/qcom_clk/qcom_clk_apssdiv.c

Loading...

sys/dev/qcom_clk/qcom_clk_rcg2.c

Loading...