acpi: Unmap RSDP in more error cases
ClosedPublic
Actions

Authored by imp on Aug 31 2022, 3:58 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Mar 28, 6:12 AM

	Unknown Object (File)
	Sat, Mar 8, 11:35 AM

	Unknown Object (File)
	Feb 27 2025, 1:41 PM

	Unknown Object (File)
	Feb 26 2025, 3:20 AM

	Unknown Object (File)
	Feb 21 2025, 10:56 AM

	Unknown Object (File)
	Feb 21 2025, 10:35 AM

	Unknown Object (File)
	Feb 10 2025, 10:59 PM

	Unknown Object (File)
	Feb 7 2025, 10:58 PM

View All 35 Files

Subscribers

andrew

emaste

Details

Reviewers

jhb
manu
andrew

Commits

rGa14b26a6bd3f: acpi: Unmap RSDP in more error cases

Summary

Add missing pmap_unmapbios() calls for when we return 0. Otherwise we
can leave the table mapped when it is of no use.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 47204
Build 44091: arc lint + arc unit

Event Timeline

imp created this revision.Aug 31 2022, 3:58 PM

Herald added a reviewer: manu. · View Herald TranscriptAug 31 2022, 3:58 PM

Herald added subscribers: emaste, andrew. · View Herald Transcript

Harbormaster completed remote builds in B47204: Diff 110019.Aug 31 2022, 3:58 PM

imp requested review of this revision.Aug 31 2022, 3:58 PM

imp added a reviewer: andrew.Aug 31 2022, 4:00 PM

andrew accepted this revision.Sep 1 2022, 9:37 AM

This revision is now accepted and ready to land.Sep 1 2022, 9:37 AM

Closed by commit rGa14b26a6bd3f: acpi: Unmap RSDP in more error cases (authored by imp). · Explain WhySep 1 2022, 4:44 PM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rGa14b26a6bd3f: acpi: Unmap RSDP in more error cases.

Revision Contents
Changeset List

Path

Size

sys/

amd64/

acpica/

acpi_machdep.c

6 lines

arm64/

acpica/

acpi_machdep.c

2 lines

Diff 110019

View Options

sys/amd64/acpica/acpi_machdep.c