net80211: ieee80211_ies_expand() add extra length check
ClosedPublic
Actions

Authored by bz on Aug 17 2022, 4:52 PM.

Details

Reviewers

Group Reviewers

Commits

rG31b4fa3dbcf1: net80211: ieee80211_ies_expand() add extra length check
rG9d2ba51806c3: net80211: ieee80211_ies_expand() add extra length check

Summary

Make sure the given IE length fits into the total length left when
parsing through the information elements. In theory I would say
discard everything if this happens but that proves hard with the
current code.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46998
Build 43887: arc lint + arc unit

Event Timeline

bz created this revision.Aug 17 2022, 4:52 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptAug 17 2022, 4:52 PM

bz requested review of this revision.Aug 17 2022, 4:52 PM

Harbormaster completed remote builds in B46998: Diff 109467.Aug 17 2022, 4:52 PM

nice catch!

This revision is now accepted and ready to land.Aug 17 2022, 4:54 PM

Closed by commit rG9d2ba51806c3: net80211: ieee80211_ies_expand() add extra length check (authored by bz). · Explain WhyAug 18 2022, 8:32 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rG9d2ba51806c3: net80211: ieee80211_ies_expand() add extra length check.

bz added a commit: rG31b4fa3dbcf1: net80211: ieee80211_ies_expand() add extra length check.Sep 21 2022, 2:03 PM

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_node.c

8 lines

Diff 109467

View Options

sys/net80211/ieee80211_node.c

net80211: ieee80211_ies_expand() add extra length checkClosedPublicActions