Differential D34345

iconv_std: complete the //IGNORE support
ClosedPublic
Actions

Authored by kevans on Feb 22 2022, 5:26 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 5, 9:05 PM

	Unknown Object (File)
	Mon, Jun 30, 3:20 PM

	Unknown Object (File)
	Sun, Jun 29, 6:15 PM

	Unknown Object (File)
	Sun, Jun 29, 4:57 AM

	Unknown Object (File)
	Thu, Jun 26, 5:32 PM

	Unknown Object (File)
	Thu, Jun 26, 7:46 AM

	Unknown Object (File)
	Sat, Jun 14, 12:29 PM

	Unknown Object (File)
	Jun 9 2025, 9:46 AM

View All 94 Files

Subscribers

Details

Reviewers

jrtc27
emaste

Group Reviewers

Commits

rG693f88c9da8d: iconv_std: complete the //IGNORE support

Summary

Previously, it would only ignore failures due to csmapper conversion
failure. It may be the case that the input string contains invalid
sequences that also need to be ignored.

A good example of //IGNORE application is sanitizing user- or remotely-
specified strings that are expected to be UTF-8; perhaps as part of a
pipeline that will feed the result into a system less tested against or
tolerant of illegal UTF-8 sequences.

Sponsored by: Klara, Inc.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Feb 22 2022, 5:26 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 22 2022, 5:26 PM

kevans requested review of this revision.Feb 22 2022, 5:26 PM

kevans added a parent revision: D34344: libc: iconv: add mb_cur_min for encoder traits.

Harbormaster completed remote builds in B44538: Diff 103112.Feb 22 2022, 5:26 PM

This revision was not accepted when it landed; it landed in state Needs Review.Aug 11 2022, 4:44 PM

Closed by commit rG693f88c9da8d: iconv_std: complete the //IGNORE support (authored by kevans). · Explain Why

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rG693f88c9da8d: iconv_std: complete the //IGNORE support.

Revision Contents
Changeset List

Path

Size

lib/

libiconv_modules/

iconv_std/

citrus_iconv_std.c

18 lines

Diff 109194

lib/libiconv_modules/iconv_std/citrus_iconv_std.c

Loading...