Page MenuHomeFreeBSD
Differential D36102

linuxkpi: acpi/video.h: Add stubs acpi_video_{register,unregister}
ClosedPublic
Actions

Authored by manu on Aug 10 2022, 6:47 AM.
Tags
None
Referenced Files
F171173788: D36102.id109148.diff
Wed, Sep 9, 6:03 AM
F171173782: D36102.id109087.diff
Wed, Sep 9, 6:03 AM
F171173776: D36102.id109517.diff
Wed, Sep 9, 6:03 AM
F171173577: D36102.diff
Wed, Sep 9, 6:00 AM
Unknown Object (File)
Sun, Sep 6, 4:26 AM
Unknown Object (File)
Fri, Sep 4, 5:23 AM
Unknown Object (File)
Thu, Sep 3, 11:39 PM
Unknown Object (File)
Thu, Sep 3, 6:55 AM
View All Files
Subscribers
bz
emaste
imp
linuxkpi

Details

Reviewers
bz
Commits
rG5e477ea3b175: linuxkpi: acpi/video.h: Add stubs acpi_video_{register,unregister}
rGafe53d7f7a9c: linuxkpi: acpi/video.h: Add stubs acpi_video_{register,unregister}
Summary

Needed by i915.

Obtained from: drm-kmod
Sponsored by: Beckhoff Automation GmbH & Co. KG

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46853
Build 43742: arc lint + arc unit

Event Timeline

manu created this revision.Aug 10 2022, 6:47 AM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptAug 10 2022, 6:47 AM
manu requested review of this revision.Aug 10 2022, 6:47 AM
Harbormaster completed remote builds in B46818: Diff 109087.Aug 10 2022, 6:47 AM
manu added a parent revision: D36101: linuxkpi: pgtable: Add more defines.Aug 10 2022, 6:47 AM
manu added a child revision: D36103: linuxkpi: Add video/mipi_display.h.
bz added a subscriber: bz.Aug 10 2022, 3:29 PM
bz added inline comments.
sys/compat/linuxkpi/common/include/acpi/video.h
38

Given it's not implemented should we return an error instead of 0, (-ENXIO)?

39

do { } while(0)

manu added inline comments.Aug 10 2022, 3:56 PM
sys/compat/linuxkpi/common/include/acpi/video.h
38

It's never tested in i915 but linux does return -ENODEV if compiled without CONFIG_ACPI_VIDEO, we could do the same here.

bz added inline comments.Aug 10 2022, 4:02 PM
sys/compat/linuxkpi/common/include/acpi/video.h
38

Sounds good to me an inline with what we do in PCI for some.

manu updated this revision to Diff 109148.Aug 11 2022, 7:39 AM

Switch to inline function and return -ENODEV for the register one.

Harbormaster completed remote builds in B46853: Diff 109148.Aug 11 2022, 7:39 AM
bz accepted this revision.Aug 11 2022, 11:24 AM
This revision is now accepted and ready to land.Aug 11 2022, 11:24 AM
Closed by commit rGafe53d7f7a9c: linuxkpi: acpi/video.h: Add stubs acpi_video_{register,unregister} (authored by manu). · Explain WhyAug 18 2022, 9:13 AM
This revision was automatically updated to reflect the committed changes.
manu added a commit: rGafe53d7f7a9c: linuxkpi: acpi/video.h: Add stubs acpi_video_{register,unregister}.
manu added a commit: rG5e477ea3b175: linuxkpi: acpi/video.h: Add stubs acpi_video_{register,unregister}.Sep 7 2022, 3:13 PM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
acpi/
12 lines

Diff 109148

View Options

sys/compat/linuxkpi/common/include/acpi/video.h

Loading...