mac_ddb: Fix the show rman validator.
ClosedPublic
Actions

Authored by jhb on Aug 10 2022, 11:19 PM.

Details

Reviewers

imp
mhorne

Commits

rG3a3af6b2a160: mac_ddb: Fix the show rman validator.

Summary

The validator always returned true due to an incorrect check.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46842
Build 43731: arc lint + arc unit

Event Timeline

jhb created this revision.Aug 10 2022, 11:19 PM

Herald added a subscriber: imp. · View Herald TranscriptAug 10 2022, 11:19 PM

jhb requested review of this revision.Aug 10 2022, 11:19 PM

Harbormaster completed remote builds in B46842: Diff 109130.Aug 10 2022, 11:19 PM

FWIW, in downstream CheriBSD I've basically changed all of these to not use void * casts and instead cast the first item to an integer type (think uintptr_t).

imp accepted this revision.Aug 10 2022, 11:20 PM

imp added inline comments.

sys/security/mac_ddb/mac_ddb.c
188	the second one certainly is more discriminating :)

This revision is now accepted and ready to land.Aug 10 2022, 11:20 PM

In D36125#820154, @jhb wrote:

FWIW, in downstream CheriBSD I've basically changed all of these to not use void * casts and instead cast the first item to an integer type (think uintptr_t).

I think that's a better fix to compare against db_expr_t anyway.

Yikes! Thank you.

Closed by commit rG3a3af6b2a160: mac_ddb: Fix the show rman validator. (authored by jhb). · Explain WhyAug 12 2022, 5:21 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG3a3af6b2a160: mac_ddb: Fix the show rman validator..