Page MenuHomeFreeBSD

mac_ddb: Fix the show rman validator.
ClosedPublic

Authored by jhb on Aug 10 2022, 11:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 5, 3:29 AM
Unknown Object (File)
Fri, Oct 31, 5:50 AM
Unknown Object (File)
Wed, Oct 29, 2:18 PM
Unknown Object (File)
Wed, Oct 29, 10:44 AM
Unknown Object (File)
Wed, Oct 29, 9:53 AM
Unknown Object (File)
Wed, Oct 29, 8:38 AM
Unknown Object (File)
Wed, Oct 29, 8:18 AM
Unknown Object (File)
Oct 3 2025, 5:09 PM

Details

Summary

The validator always returned true due to an incorrect check.

Sponsored by: DARPA

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Aug 10 2022, 11:19 PM

FWIW, in downstream CheriBSD I've basically changed all of these to not use void * casts and instead cast the first item to an integer type (think uintptr_t).

imp added inline comments.
sys/security/mac_ddb/mac_ddb.c
188

the second one certainly is more discriminating :)

This revision is now accepted and ready to land.Aug 10 2022, 11:20 PM
In D36125#820154, @jhb wrote:

FWIW, in downstream CheriBSD I've basically changed all of these to not use void * casts and instead cast the first item to an integer type (think uintptr_t).

I think that's a better fix to compare against db_expr_t anyway.

This revision was automatically updated to reflect the committed changes.