Page MenuHomeFreeBSD
Differential D36078

atomic: Add atomic_load/store_bool()
ClosedPublic
Actions

Authored by markj on Aug 8 2022, 6:11 PM.
Tags
None
Referenced Files
F105522166: D36078.diff
Tue, Dec 17, 5:46 AM
Unknown Object (File)
Mon, Dec 2, 1:25 AM
Unknown Object (File)
Sun, Nov 17, 6:23 PM
Unknown Object (File)
Nov 15 2024, 8:19 AM
Unknown Object (File)
Nov 8 2024, 3:03 PM
Unknown Object (File)
Nov 8 2024, 1:32 PM
Unknown Object (File)
Nov 8 2024, 11:37 AM
Unknown Object (File)
Oct 29 2024, 9:32 PM
View All 57 Files
Subscribers
imp

Details

Reviewers
kib
jhb
Commits
rG2bed73739aac: atomic: Add plain atomic_load/store_bool()
Summary

For plain accesses, I can see no reason not to provide them. They will
be useful for jhb's re-import of if_wg.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Aug 8 2022, 6:11 PM
Herald added a subscriber: imp. · View Herald TranscriptAug 8 2022, 6:11 PM
markj requested review of this revision.Aug 8 2022, 6:11 PM
Harbormaster completed remote builds in B46788: Diff 109014.Aug 8 2022, 6:11 PM
kib added inline comments.Aug 8 2022, 8:26 PM
sys/sys/atomic_common.h
42

Why #ifdef _KERNEL? Using _Bool, you can do it for userspace, I think. Also, this is a macro, so type is dormant unless the macro is actually used.

markj updated this revision to Diff 109027.Aug 8 2022, 9:23 PM

Drop _KERNEL guards, use _Bool instead.

Harbormaster completed remote builds in B46795: Diff 109027.Aug 8 2022, 9:23 PM
kib accepted this revision.Aug 8 2022, 9:29 PM
This revision is now accepted and ready to land.Aug 8 2022, 9:29 PM
Closed by commit rG2bed73739aac: atomic: Add plain atomic_load/store_bool() (authored by markj). · Explain WhyAug 9 2022, 11:03 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rG2bed73739aac: atomic: Add plain atomic_load/store_bool().
shailend_google.com mentioned this in D47138: gve: Fix TX livelock.Nov 4 2024, 5:16 PM

Revision Contents
Changeset List

PathSize
sys/
sys/
11 lines

Diff 109078

View Options

sys/sys/atomic_common.h

Loading...