Page MenuHomeFreeBSD
Differential D35952

riscv: Avoid passing invalid addresses to pmap_fault()
ClosedPublic
Actions

Authored by markj on Jul 26 2022, 5:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 11, 11:59 AM
Unknown Object (File)
Thu, Sep 10, 2:38 PM
Unknown Object (File)
Wed, Sep 9, 2:38 PM
Unknown Object (File)
Wed, Sep 9, 1:31 AM
Unknown Object (File)
Tue, Sep 8, 6:52 PM
Unknown Object (File)
Sat, Sep 5, 10:37 PM
Unknown Object (File)
Sat, Sep 5, 6:24 PM
Unknown Object (File)
Sat, Sep 5, 3:10 PM
View All Files
Subscribers
imp

Details

Reviewers
jrtc27
jhb
Group Reviewers
riscv
Commits
rG828ea49debe3: riscv: Avoid passing invalid addresses to pmap_fault()
Summary

After the addition of SV48 support, VIRT_IS_VALID() does not exclude
addresses that are in the SV39 address space hole but not in the SV48
address space hole. This can result in mishandling of accesses to that
range.

Fix the problem by modifying VIRT_IS_VALID() to use the runtime address
space bounds. Then, if the address is invalid, and pcb_onfault is set,
give vm_fault_trap() a chance to veto the access instead of panicking.

PR: 265439
Fixes: 31218f3209ac ("riscv: Add support for enabling SV48 mode")

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46603
Build 43492: arc lint + arc unit

Revision Contents
Changeset List

PathSize
sys/
riscv/
include/
5 lines
4 lines
riscv/
2 lines
7 lines

Diff 108562

View Options

sys/riscv/include/pmap.h

Loading...
View Options

sys/riscv/include/vmparam.h

Loading...
View Options

sys/riscv/riscv/pmap.c

Loading...
View Options

sys/riscv/riscv/trap.c

Loading...