Page MenuHomeFreeBSD
Differential D35877

Add tests for wc(1)
AbandonedPublic
Actions

Authored by lwhsu on Jul 22 2022, 7:06 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 21 2025, 11:32 PM
Unknown Object (File)
Dec 13 2025, 5:48 AM
Unknown Object (File)
Nov 28 2025, 1:34 AM
Unknown Object (File)
Nov 7 2025, 3:22 AM
Unknown Object (File)
Nov 5 2025, 2:15 AM
Unknown Object (File)
Nov 4 2025, 8:59 AM
Unknown Object (File)
Nov 3 2025, 1:23 PM
Unknown Object (File)
Nov 3 2025, 1:20 PM
View All 89 Files
Subscribers
emaste
imp
ngie
Contributor Reviews (src)

Details

Reviewers
ngie
aokblast
Group Reviewers
tests

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46540
Build 43429: arc lint + arc unit

Event Timeline

aokblast created this revision.Jul 22 2022, 7:06 AM
Herald added subscribers: Contributor Reviews (src), imp. · View Herald TranscriptJul 22 2022, 7:06 AM
aokblast requested review of this revision.Jul 22 2022, 7:06 AM
Harbormaster completed remote builds in B46507: Diff 108407.Jul 22 2022, 7:06 AM
lwhsu added reviewers: lwhsu, tests.Jul 22 2022, 7:07 AM
lwhsu retitled this revision from Add tests for wc to Add tests for wc(1).Jul 22 2022, 7:13 AM
ngie requested changes to this revision.Jul 22 2022, 2:01 PM
ngie added a subscriber: ngie.
ngie added inline comments.
usr.bin/wc/tests/04_zh-TW.in
2

Does this require libiconv or any special build options to test?

usr.bin/wc/tests/wc_test.sh
2

Please omit -- it gets added by the build.

The copyright header is missing BTW (it doesn't matter a ton -- just a minor inconsistency).

3–84
  • Please don't use camelCase names.
  • Please avoid line continuations like this -- it makes the descriptions more difficult to grep for.
27

I might name this "total_bytes_ascii"

46

I might name this "total_bytes_utf8" (it matters more that non-ASCII is used than the specific locale that's used).

This revision now requires changes to proceed.Jul 22 2022, 2:01 PM
aokblast updated this revision to Diff 108479.Jul 24 2022, 10:45 PM
  • Fix naming convension for wc test case
Harbormaster completed remote builds in B46540: Diff 108479.Jul 24 2022, 10:45 PM
lwhsu mentioned this in D38496: wc: Clean up and modernize..Feb 11 2023, 9:43 AM
emaste added a subscriber: emaste.Feb 15 2023, 2:40 AM
lwhsu commandeered this revision.Feb 15 2023, 5:18 AM
lwhsu abandoned this revision.
lwhsu edited reviewers, added: aokblast; removed: lwhsu.
lwhsu marked 3 inline comments as done.

Covered by dad64f0e7cadb5913d6463fc014f59f8706d316c.

Revision Contents
Changeset List

PathSize
etc/
mtree/
2 lines
usr.bin/
wc/
3 lines
tests/
3 lines
9 lines
4 lines
1 line
12 lines
86 lines

Diff 108479

View Options

etc/mtree/BSD.tests.dist

Loading...
View Options

usr.bin/wc/Makefile

Loading...
View Options

usr.bin/wc/tests/01_longest_line.in

Loading...
View Options

usr.bin/wc/tests/02_new_lines.in

Loading...
View Options

usr.bin/wc/tests/03_tot_bytes.in

Loading...
View Options

usr.bin/wc/tests/04_zh-TW.in

Loading...
View Options

usr.bin/wc/tests/Makefile

Loading...
View Options

usr.bin/wc/tests/wc_test.sh

Loading...