Page MenuHomeFreeBSD
Differential D35880

Convert runtime param checks to KASSERTs for fo_fspacectl
ClosedPublic
Actions

Authored by khng on Jul 22 2022, 6:11 PM.
Tags
None
Referenced Files
F140068854: D35880.diff
Fri, Dec 19, 7:49 PM
F140055293: D35880.diff
Fri, Dec 19, 3:17 PM
Unknown Object (File)
Nov 13 2025, 1:19 PM
Unknown Object (File)
Nov 12 2025, 6:35 PM
Unknown Object (File)
Nov 11 2025, 4:28 PM
Unknown Object (File)
Nov 8 2025, 5:57 PM
Unknown Object (File)
Nov 8 2025, 4:19 PM
Unknown Object (File)
Nov 4 2025, 4:06 AM
View All Files
Subscribers
imp

Details

Reviewers
kib
markj
Commits
rG8c9aa94b42bf: Convert runtime param checks to KASSERTs for fo_fspacectl

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 46512
Build 43401: arc lint + arc unit

Event Timeline

khng created this revision.Jul 22 2022, 6:11 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 22 2022, 6:11 PM
khng requested review of this revision.Jul 22 2022, 6:11 PM
Harbormaster completed remote builds in B46512: Diff 108415.Jul 22 2022, 6:11 PM
markj accepted this revision.Jul 22 2022, 11:27 PM
markj added inline comments.
sys/kern/vfs_vnops.c
3611

There is also SPACECTL_F_SUPPORTED.

3613

IMHO, it's nicer to be consistent and use the same set of assertions in both functions. (The third one uses local vars above, but not here.)

This revision is now accepted and ready to land.Jul 22 2022, 11:27 PM
Closed by commit rG8c9aa94b42bf: Convert runtime param checks to KASSERTs for fo_fspacectl (authored by khng). · Explain WhyJul 23 2022, 7:17 PM
This revision was automatically updated to reflect the committed changes.
khng added a commit: rG8c9aa94b42bf: Convert runtime param checks to KASSERTs for fo_fspacectl.

Revision Contents
Changeset List

PathSize
sys/
kern/
9 lines
7 lines

Diff 108415

View Options

sys/kern/uipc_shm.c

Loading...
View Options

sys/kern/vfs_vnops.c

Loading...