Convert runtime param checks to KASSERTs for fo_fspacectl
ClosedPublic
Actions

Authored by khng on Jul 22 2022, 6:11 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Oct 21, 9:21 PM

	Unknown Object (File)
	Wed, Oct 15, 6:03 AM

	Unknown Object (File)
	Tue, Oct 14, 5:53 AM

	Unknown Object (File)
	Mon, Oct 13, 1:56 AM

	Unknown Object (File)
	Mon, Oct 13, 1:56 AM

	Unknown Object (File)
	Mon, Oct 13, 1:56 AM

	Unknown Object (File)
	Sun, Oct 12, 2:10 PM

	Unknown Object (File)
	Sat, Oct 11, 1:38 PM

View All 87 Files

Subscribers

imp

Details

Reviewers

kib
markj

Commits

rG8c9aa94b42bf: Convert runtime param checks to KASSERTs for fo_fspacectl

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46512
Build 43401: arc lint + arc unit

Event Timeline

khng created this revision.Jul 22 2022, 6:11 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 22 2022, 6:11 PM

khng requested review of this revision.Jul 22 2022, 6:11 PM

Harbormaster completed remote builds in B46512: Diff 108415.Jul 22 2022, 6:11 PM

markj accepted this revision.Jul 22 2022, 11:27 PM

markj added inline comments.

sys/kern/vfs_vnops.c
3611	There is also SPACECTL_F_SUPPORTED.
3613	IMHO, it's nicer to be consistent and use the same set of assertions in both functions. (The third one uses local vars above, but not here.)

This revision is now accepted and ready to land.Jul 22 2022, 11:27 PM

Closed by commit rG8c9aa94b42bf: Convert runtime param checks to KASSERTs for fo_fspacectl (authored by khng). · Explain WhyJul 23 2022, 7:17 PM

This revision was automatically updated to reflect the committed changes.

khng added a commit: rG8c9aa94b42bf: Convert runtime param checks to KASSERTs for fo_fspacectl.

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_shm.c

9 lines

vfs_vnops.c

7 lines

Diff 108415

View Options

sys/kern/uipc_shm.c