vm: Remove handling for OBJT_DEFAULT objects
ClosedPublic
Actions

Authored by markj on Jul 12 2022, 4:22 PM.

Details

Reviewers

dougm
alc
kib

Commits

rG0cb2610ee2dc: vm: Remove handling for OBJT_DEFAULT objects

Summary

Now that OBJT_DEFAULT objects can't be instantiated, we can simplify
various checks of the form `object->type == OBJT_DEFAULT ||
(object->flags & OBJ_SWAP) != 0`. No functional change intended.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46404
Build 43293: arc lint + arc unit

Event Timeline

markj created this revision.Jul 12 2022, 4:22 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 12 2022, 4:22 PM

markj requested review of this revision.Jul 12 2022, 4:22 PM

Harbormaster completed remote builds in B46385: Diff 108060.Jul 12 2022, 4:23 PM

markj added a parent revision: D35787: vm_object: Release object swap charge in the swap pager destructor.Jul 12 2022, 4:23 PM

markj added a child revision: D35789: vm_object: Remove redundant OBJ_SWAP checks.

kib accepted this revision.Jul 12 2022, 4:55 PM

This revision is now accepted and ready to land.Jul 12 2022, 4:55 PM

alc accepted this revision.Jul 13 2022, 7:51 AM

Remove a stale comment from vm_object_split().

This revision now requires review to proceed.Jul 13 2022, 1:23 PM

Harbormaster completed remote builds in B46404: Diff 108097.Jul 13 2022, 1:23 PM

markj mentioned this in D35789: vm_object: Remove redundant OBJ_SWAP checks.Jul 13 2022, 1:25 PM

alc accepted this revision.Jul 13 2022, 3:05 PM

alc added inline comments.

sys/vm/vm_object.c
1526–1527	As an aside, I don't see why we pass a charge to vm_object_allocate_anon(). Currently, the passed charge is always equal to ptoa(size). Moreover, I'm skeptical that there will be a future scenario where it differs.

This revision is now accepted and ready to land.Jul 13 2022, 3:05 PM

Closed by commit rG0cb2610ee2dc: vm: Remove handling for OBJT_DEFAULT objects (authored by markj). · Explain WhyJul 17 2022, 11:26 AM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG0cb2610ee2dc: vm: Remove handling for OBJT_DEFAULT objects.