routing: improve debug logging
ClosedPublic
Actions

Authored by melifaro on Jun 19 2022, 8:13 PM.

Details

Reviewers

None

Group Reviewers

network

Commits

rGcda085d1ccef: routing: improve debug logging
rG5d6894bd66e1: routing: improve debug logging

Summary

Use standard logging (FIB_XX_LOG) across nhg code instead of using old-style DPRINTFs.
Add debug object printer for nhgs (nhgrp_print_buf).

Example:

Jun 19 20:17:09 devel2 kernel: [nhgrp] inet.0 nhgrp_ctl_alloc_default: multipath init done
Jun 19 20:17:09 devel2 kernel: [nhg_ctl] inet.0 alloc_nhgrp: num_nhops: 2, compiled_nhop: 2

Jun 19 20:17:26 devel2 kernel: [nhg_ctl] inet.0 alloc_nhgrp: num_nhops: 3, compiled_nhop: 3
Jun 19 20:17:26 devel2 kernel: [nhg_ctl] inet.0 destroy_nhgrp: destroying nhg#0/sz=2:[#6:1,#5:1]

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 46031
Build 42920: arc lint + arc unit

Event Timeline

melifaro created this revision.Jun 19 2022, 8:13 PM

Herald added subscribers: glebius, ae, imp. · View Herald TranscriptJun 19 2022, 8:13 PM

melifaro requested review of this revision.Jun 19 2022, 8:13 PM

Harbormaster completed remote builds in B46031: Diff 107168.Jun 19 2022, 8:13 PM

melifaro retitled this revision from routing: add fancy nhg printer; use standard debug logging across routing code to routing: improve debug logging.Jun 19 2022, 8:19 PM

melifaro edited the summary of this revision. (Show Details)

melifaro added a reviewer: network.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 22 2022, 3:59 PM

Closed by commit rG5d6894bd66e1: routing: improve debug logging (authored by melifaro). · Explain Why

This revision was automatically updated to reflect the committed changes.

melifaro added a commit: rG5d6894bd66e1: routing: improve debug logging.

melifaro added a commit: rGcda085d1ccef: routing: improve debug logging.Jan 13 2023, 9:25 PM