iommu_gas: eliminate unneeded wrappers
ClosedPublic
Actions

Authored by alc on Jun 14 2022, 6:56 PM.

Details

Reviewers

dougm
kib
br

Commits

rGa408ed1c928a: iommu_gas: Eliminate unnecessary wrappers
rGfc2e4f15a904: iommu_gas: Eliminate unnecessary wrappers

Summary

Eliminate trivial wrappers for several iommu_gas functions. These wrappers serve no functional purpose.

Test Plan

Tested with netperf on amd64. On arm64, a kernel with the IOMMU option compiles.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alc requested review of this revision.Jun 14 2022, 6:56 PM

alc created this revision.

alc added a reviewer: br.Jun 14 2022, 6:58 PM

The idea of these wrappers was to abstract function names, i.e. make them looking generic by removing name "gas". I'm not sure what "gas" stands for, but there is no such thing on arm64.

so with this I can use iommu_map() in my ARM Komeda display controller driver (part of cheribsd), not confusing anyone with 'gas'

sys/dev/drm/komeda/komeda_plane.c:      error = iommu_map(iodom,

In D35487#804780, @br wrote:

The idea of these wrappers was to abstract function names, i.e. make them looking generic by removing name "gas". I'm not sure what "gas" stands for, but there is no such thing on arm64.

I believe that it stood for "guest address space".

I also considered renaming iommu_gas_map, etc. to iommu_map, etc., but that entailed more changes. Nonetheless, I would be happy to take that approach.

In D35487#804790, @alc wrote:

In D35487#804780, @br wrote:

The idea of these wrappers was to abstract function names, i.e. make them looking generic by removing name "gas". I'm not sure what "gas" stands for, but there is no such thing on arm64.

I believe that it stood for "guest address space".

I also considered renaming iommu_gas_map, etc. to iommu_map, etc., but that entailed more changes. Nonetheless, I would be happy to take that approach.