Page MenuHomeFreeBSD
Differential D35486

make iommu_gas_lowermatch non-recursive
ClosedPublic
Actions

Authored by dougm on Jun 14 2022, 6:31 PM.
Tags
None
Referenced Files
F166839236: D35486.id106942.diff
Sun, Aug 16, 11:19 PM
F166839053: D35486.id106954.diff
Sun, Aug 16, 11:15 PM
F166835803: D35486.id106941.diff
Sun, Aug 16, 10:15 PM
F166833184: D35486.diff
Sun, Aug 16, 9:55 PM
Unknown Object (File)
Wed, Aug 12, 12:26 PM
Unknown Object (File)
Wed, Aug 12, 12:25 PM
Unknown Object (File)
Sun, Jul 26, 8:58 PM
Unknown Object (File)
Sat, Jul 25, 2:36 AM
View All Files
Subscribers
imp

Details

Reviewers
alc
kib
Commits
rG3a33ebe65fce: iommu_gas: make iommu_gas_lowermatch non-recursive
rGf979ad003065: iommu_gas: make iommu_gas_lowermatch non-recursive
Summary

make iommu_gas_lowermatch non-recursive, and still first-fitting.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

dougm requested review of this revision.Jun 14 2022, 6:31 PM
dougm created this revision.
alc added inline comments.Jun 14 2022, 10:39 PM
sys/dev/iommu/iommu_gas.c
411

Deindent this line by 4 spaces.

dougm updated this revision to Diff 106938.Jun 15 2022, 1:51 AM
dougm marked an inline comment as done.

Fix indent.

alc added a comment.Jun 15 2022, 5:33 AM

I'd estimate that this change increases the achieved bandwidth by netperf TCP_MAERTS from about 3500-3550Mbps to 3650-3700MBps.

dougm updated this revision to Diff 106941.Jun 15 2022, 5:59 AM

Enhance comments.

dougm updated this revision to Diff 106942.Jun 15 2022, 6:18 AM

Add braces.

alc accepted this revision.Jun 15 2022, 6:20 AM
This revision is now accepted and ready to land.Jun 15 2022, 6:20 AM
dougm added a reviewer: kib.Jun 15 2022, 6:22 AM
kib accepted this revision.Jun 15 2022, 2:36 PM
Closed by commit rGf979ad003065: iommu_gas: make iommu_gas_lowermatch non-recursive (authored by dougm). · Explain WhyJun 15 2022, 4:37 PM
This revision was automatically updated to reflect the committed changes.
dougm added a commit: rGf979ad003065: iommu_gas: make iommu_gas_lowermatch non-recursive.
Herald added a subscriber: imp. · View Herald TranscriptJun 15 2022, 4:37 PM
dougm added a commit: rG3a33ebe65fce: iommu_gas: make iommu_gas_lowermatch non-recursive.Jul 6 2022, 5:05 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
iommu/
76 lines

Diff 106942

View Options

sys/dev/iommu/iommu_gas.c

Loading...