Details

Reviewers

koobs
meta

Commits

R11:8341f685dd02: mail/py-rfc6555: Happy Eyeballs Algorithm described in RFC 6555 (new port)

Summary

Dependency of: mail/py-offlineimap3
PR: 262231

[NEW] mail/py-rfc6555: Happy Eyeballs Algorithm described in RFC 6555

Synchronous Python implementation of the Happy Eyeballs Algorithm
described in RFC 6555. Provided with a single file and dead-simple
API to allow easy vendoring and integration into other projects.

WWW: https://github.com/sethmlarson/rfc6555

Test Plan

portlint: ok. looks fine.
testport: 13amd64.
maketest: 23 passed in 0.47 seconds
other: Test with py-offlineimap3. Been using the 8.0.0 python3 version in a venv via pip-install for over a week and pkg install version for a couple days.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 45879
Build 42767: arc lint + arc unit

Event Timeline

dereks_lifeofadishwasher.com created this revision.Feb 28 2022, 3:29 AM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptFeb 28 2022, 3:29 AM

dereks_lifeofadishwasher.com requested review of this revision.Feb 28 2022, 3:29 AM

Harbormaster completed remote builds in B44588: Diff 103276.Feb 28 2022, 3:29 AM

tests are not included in sdist. Requested here: https://github.com/sethmlarson/rfc6555/pull/8

koobs retitled this revision from mail/py-rfc6555: New port mail/py-rfc6555 to [NEW] mail/py-rfc6555: Happy Eyeballs Algorithm described in RFC 6555.Mar 2 2022, 10:33 PM

koobs edited the summary of this revision. (Show Details)

koobs edited the test plan for this revision. (Show Details)

koobs added a reviewer: koobs.

koobs added a project: Python.

Add TEST_DEPENDS and (do-)test target for QA
Need confirmation of QA in TEST PLAN

This revision now requires changes to proceed.Mar 2 2022, 10:35 PM

Added tests and moved to github until tests are added

Harbormaster completed remote builds in B44645: Diff 103471.Mar 3 2022, 11:48 PM

dereks_lifeofadishwasher.com edited the summary of this revision. (Show Details)Mar 3 2022, 11:50 PM

dereks_lifeofadishwasher.com edited the test plan for this revision. (Show Details)

All review comments have been addressed. LGTM.

@koobs Anything else?

Upstream updated https://github.com/sethmlarson/rfc6555/pull/8 and prefer not to add test to sdist.

So it's possible to keep everything as is, a full github port, pypi pulling in tests from github, or pypi adding tests to FILES_DIR.

koobs requested changes to this revision.Jun 5 2022, 11:11 PM

koobs added inline comments.

mail/py-rfc6555/Makefile
17	I'd add comment with upstream ref to PR/issue saying tests are not packaged, and they don't want to. Save people and our future selves from wondering why.
18–19	Minor item: Group/sort USE/USES (unless portfmt/portclippy/portlint somehow disagree these days?)