pf: still one leak in here so switch all to M_NVLIST
ClosedPublic
Actions

Authored by franco_opnsense.org on Jun 2 2022, 12:53 PM.

Details

Reviewers

Commits

rG4f9d5dcc4510: pf: fix more syncookie memory leaks
rG329c9b9da592: pf: fix more syncookie memory leaks
rGa37e0e6de652: pf: fix more syncookie memory leaks

Summary

syncookie still leaks nvlist likely through nvlist_pack().
To avoid future issues (also due to copy/paste) move all
remaining uses of M_TEMP to M_NVLIST as well where appropriate.

Test Plan

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45814
Build 42702: arc lint + arc unit

Event Timeline

franco_opnsense.org created this revision.Jun 2 2022, 12:53 PM

Herald added subscribers: Contributor Reviews (src), glebius, melifaro and 2 others. · View Herald TranscriptJun 2 2022, 12:53 PM

franco_opnsense.org requested review of this revision.Jun 2 2022, 12:53 PM

Harbormaster completed remote builds in B45814: Diff 106569.Jun 2 2022, 12:54 PM

franco_opnsense.org edited the test plan for this revision. (Show Details)Jun 2 2022, 12:57 PM

franco_opnsense.org added a reviewer: kp.

This revision was not accepted when it landed; it landed in state Needs Review.Jun 2 2022, 6:18 PM

Closed by commit rGa37e0e6de652: pf: fix more syncookie memory leaks (authored by franco_opnsense.org, committed by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGa37e0e6de652: pf: fix more syncookie memory leaks.

kp added a commit: rG329c9b9da592: pf: fix more syncookie memory leaks.Jun 6 2022, 11:47 AM

kp added a commit: rG4f9d5dcc4510: pf: fix more syncookie memory leaks.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf_ioctl.c

20 lines

pf_syncookies.c

6 lines

Diff 106569

View Options

sys/netpfil/pf/pf_ioctl.c