unix/*: check new control size in unp_internalize()
ClosedPublic
Actions

Authored by glebius on May 25 2022, 7:31 AM.

Details

Reviewers

Commits

rG579b45e20328: unix/*: check new control size in unp_internalize()

Summary

Now that we call sbcreatecontrol() with M_WAITOK, we are expected to
pass a valid size. Return same error code, we are returning for an
oversized control from sockargs().

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45705
Build 42593: arc lint + arc unit

Event Timeline

glebius created this revision.May 25 2022, 7:31 AM

Herald added a subscriber: imp. · View Herald TranscriptMay 25 2022, 7:31 AM

glebius requested review of this revision.May 25 2022, 7:31 AM

Harbormaster completed remote builds in B45705: Diff 106356.May 25 2022, 7:31 AM

glebius added a parent revision: D35316: sockets: return EMSGSIZE if control part of message is too large.May 25 2022, 7:31 AM

markj accepted this revision.May 25 2022, 7:43 PM

markj added inline comments.

sys/kern/uipc_usrreq.c
2244
2249	I'm not sure this is truly insane. libcasper can provoke such situations.

This revision is now accepted and ready to land.May 25 2022, 7:43 PM

Closed by commit rG579b45e20328: unix/*: check new control size in unp_internalize() (authored by glebius). · Explain WhyMay 25 2022, 8:30 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG579b45e20328: unix/*: check new control size in unp_internalize().

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_usrreq.c

14 lines

Diff 106356

View Options

unix/*: check new control size in unp_internalize()ClosedPublicActions