Paths

Table of Contentst

Differential D35210

net-p2p/litecoin: update to 0.21.2
ClosedPublic
Actions

Authored by hsw_bitmark.com on May 15 2022, 11:16 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 22, 7:03 AM

	Unknown Object (File)
	Tue, Apr 9, 2:25 AM

	Unknown Object (File)
	Mon, Apr 8, 11:25 PM

	Unknown Object (File)
	Thu, Apr 4, 4:54 AM

	Unknown Object (File)
	Thu, Apr 4, 4:54 AM

	Unknown Object (File)
	Thu, Apr 4, 4:54 AM

	Unknown Object (File)
	Thu, Apr 4, 4:53 AM

	Unknown Object (File)
	Thu, Apr 4, 4:52 AM

View All 55 Files

Subscribers

Details

Reviewers

Group Reviewers

Contributor Reviewers (ports)

Commits

R11:0f607032e9e5: net-p2p/litecoin: update to 0.21.2

Summary

Update litecoin and associated ports to 0.21.2

Test Plan

poudriere bulk -j 13_0-amd64 net-p2p/litecoin net-p2p/litecoin-daemon net-p2p/litecoin-utils

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

hsw_bitmark.com created this revision.May 15 2022, 11:16 AM

Herald added a subscriber: mat. · View Herald TranscriptMay 15 2022, 11:16 AM

hsw_bitmark.com requested review of this revision.May 15 2022, 11:16 AM

Harbormaster completed remote builds in B45581: Diff 106007.May 15 2022, 11:17 AM

arrowd added a subscriber: arrowd.May 15 2022, 1:56 PM

arrowd added inline comments.

net-p2p/litecoin/files/patch-src_libmw_deps_ghc_include_ghc_filesystem.hpp
18	Why this is needed?

It was a way to get the right strerror_r when I compiled the #else was selected contains:

char *msg = strerror_r(...

This line fails because FreeBSD strerror_r returns int, so I added an extra definition to selct the right strerror_r.

Is there a better way.

In D35210#798274, @hsw_bitmark.com wrote:

Is there a better way.

I believe, the better way is to define _POSIX_C_SOURCE to 200112L. Either globally via CPPFLAGS or only for that file with simple #define at the top.

thanks, I will try that

(b)db5 is deprecated, see https://cgit.freebsd.org/ports/commit/?id=64fde89d49029e00b86e66041f3dfda16725ead7

Best regards,
Daniel

net-p2p/litecoin/Makefile
67	Instead of defining it multiple times why not just set it globally? There's also a helper for this, USES= localbase:ldflags https://cgit.freebsd.org/ports/tree/Mk/Uses/localbase.mk

diizzy added inline comments.May 16 2022, 12:18 PM

net-p2p/litecoin/Makefile
1–2	Style fix, PORTVERSION --> DISTVERSION and order of variables should be changed: See Example 17. Use of USE_GITHUB with DISTVERSIONPREFIX in Porters Handbook

diizzy added inline comments.May 16 2022, 12:21 PM

net-p2p/litecoin/Makefile
67	Typed a bit too fast, USES= localbase (without :ldflags) would be the corresponding helper Sorry about that

simplify patch and Makefiles

Harbormaster completed remote builds in B45620: Diff 106139.May 18 2022, 1:54 PM

This doesn't seem to apply on the top of main branch. Can you please rebase?

rebase on main

Harbormaster completed remote builds in B45628: Diff 106153.May 19 2022, 7:24 AM

arrowd accepted this revision as: arrowd.May 24 2022, 12:37 PM

This revision is now accepted and ready to land.May 24 2022, 12:37 PM

Closed by commit R11:0f607032e9e5: net-p2p/litecoin: update to 0.21.2 (authored by hsw_bitmark.com, committed by arrowd). · Explain WhyMay 24 2022, 12:39 PM

This revision was automatically updated to reflect the committed changes.

arrowd added a commit: R11:0f607032e9e5: net-p2p/litecoin: update to 0.21.2.

Pushed in, thanks.

Sorry for taking this so long, it was keep falling out of my radar.

Note that the TEST option is broken by the recent Boost upgrade.

Revision Contents
Changeset List

Path

Size

net-p2p/

litecoin-daemon/

2 lines

litecoin-utils/

7 lines

litecoin/

15 lines

6 lines

files/

patch-src_libmw_deps_ghc_include_ghc_filesystem.hpp

15 lines

Diff 106316

net-p2p/litecoin-daemon/Makefile

Loading...

net-p2p/litecoin-utils/Makefile

Loading...

net-p2p/litecoin/Makefile

Loading...

net-p2p/litecoin/distinfo

Loading...

net-p2p/litecoin/files/patch-src_libmw_deps_ghc_include_ghc_filesystem.hpp

Loading...