net-p2p/litecoin: update to 0.21.2

[hsw_bitmark.com]

Summary

Update litecoin and associated ports to 0.21.2

Test Plan

poudriere bulk -j 13_0-amd64 net-p2p/litecoin net-p2p/litecoin-daemon net-p2p/litecoin-utils

[arrowd]

net-p2p/litecoin/files/patch-src_libmw_deps_ghc_include_ghc_filesystem.hpp

18

Why this is needed?

[hsw_bitmark.com]

It was a way to get the right strerror_r when I compiled the #else was selected contains:

char *msg = strerror_r(...

This line fails because FreeBSD strerror_r returns int, so I added an extra definition to selct the right strerror_r.

Is there a better way.

[arrowd]

In D35210#798274, @hsw_bitmark.com wrote:

Is there a better way.

I believe, the better way is to define _POSIX_C_SOURCE to 200112L. Either globally via CPPFLAGS or only for that file with simple #define at the top.

[hsw_bitmark.com]

thanks, I will try that

[diizzy]

(b)db5 is deprecated, see https://cgit.freebsd.org/ports/commit/?id=64fde89d49029e00b86e66041f3dfda16725ead7

Best regards,
Daniel

net-p2p/litecoin/Makefile

67

Instead of defining it multiple times why not just set it globally?
There's also a helper for this, USES= localbase:ldflags
https://cgit.freebsd.org/ports/tree/Mk/Uses/localbase.mk

[diizzy]

net-p2p/litecoin/Makefile

1–2

Style fix, PORTVERSION --> DISTVERSION and order of variables should be changed:
See Example 17. Use of USE_GITHUB with DISTVERSIONPREFIX in Porters Handbook

[diizzy]

net-p2p/litecoin/Makefile

67

Typed a bit too fast, USES= localbase (without :ldflags) would be the corresponding helper
Sorry about that

[hsw_bitmark.com]

simplify patch and Makefiles

[arrowd]

This doesn't seem to apply on the top of main branch. Can you please rebase?

[hsw_bitmark.com]

rebase on main

[arrowd]

Pushed in, thanks.

Sorry for taking this so long, it was keep falling out of my radar.

Note that the TEST option is broken by the recent Boost upgrade.