Page MenuHomeFreeBSD

net-p2p/litecoin: update to 0.21.2
ClosedPublic

Authored by hsw_bitmark.com on May 15 2022, 11:16 AM.

Details

Summary

Update litecoin and associated ports to 0.21.2

Test Plan

poudriere bulk -j 13_0-amd64 net-p2p/litecoin net-p2p/litecoin-daemon net-p2p/litecoin-utils

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 45620
Build 42508: arc lint + arc unit

Event Timeline

arrowd added inline comments.
net-p2p/litecoin/files/patch-src_libmw_deps_ghc_include_ghc_filesystem.hpp
17

Why this is needed?

It was a way to get the right strerror_r when I compiled the #else was selected contains:

char *msg = strerror_r(...

This line fails because FreeBSD strerror_r returns int, so I added an extra definition to selct the right strerror_r.

Is there a better way.

Is there a better way.

I believe, the better way is to define _POSIX_C_SOURCE to 200112L. Either globally via CPPFLAGS or only for that file with simple #define at the top.

net-p2p/litecoin/Makefile
66

Instead of defining it multiple times why not just set it globally?
There's also a helper for this, USES= localbase:ldflags
https://cgit.freebsd.org/ports/tree/Mk/Uses/localbase.mk

net-p2p/litecoin/Makefile
1–2

Style fix, PORTVERSION --> DISTVERSION and order of variables should be changed:
See Example 17. Use of USE_GITHUB with DISTVERSIONPREFIX in Porters Handbook

net-p2p/litecoin/Makefile
66

Typed a bit too fast, USES= localbase (without :ldflags) would be the corresponding helper
Sorry about that

This doesn't seem to apply on the top of main branch. Can you please rebase?

This revision is now accepted and ready to land.May 24 2022, 12:37 PM
This revision was automatically updated to reflect the committed changes.

Pushed in, thanks.

Sorry for taking this so long, it was keep falling out of my radar.

Note that the TEST option is broken by the recent Boost upgrade.