unix: make unp_connect2() void
ClosedPublic
Actions

Authored by glebius on May 12 2022, 7:25 PM.

Tags

None

Referenced Files

	F159153491: D35181.id.diff
	Wed, Jun 10, 5:12 PM

	F159116621: D35181.id.diff
	Wed, Jun 10, 7:38 AM

	Unknown Object (File)
	Wed, Jun 10, 12:00 AM

	Unknown Object (File)
	Tue, Jun 9, 2:28 AM

	Unknown Object (File)
	Sun, Jun 7, 3:56 PM

	Unknown Object (File)
	Mon, May 18, 11:01 AM

	Unknown Object (File)
	Fri, May 15, 5:11 PM

	Unknown Object (File)
	May 2 2026, 11:25 AM

View All Files

Subscribers

imp

Details

Reviewers

markj

Group Reviewers

network

Commits

rG08f17d143289: unix: make unp_connect2() void

Summary

Assert that sockets are of the same type. unp_connectat() already did
this check. Add the check to uipc_connect2().

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

glebius created this revision.May 12 2022, 7:25 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 12 2022, 7:25 PM

glebius requested review of this revision.May 12 2022, 7:25 PM

Harbormaster completed remote builds in B45544: Diff 105896.May 12 2022, 7:25 PM

glebius added a child revision: D35182: unix: microoptimize unp_connectat() - one less lock on success.May 12 2022, 7:25 PM

markj accepted this revision as: markj.May 12 2022, 7:52 PM

This revision is now accepted and ready to land.May 12 2022, 7:52 PM

Closed by commit rG08f17d143289: unix: make unp_connect2() void (authored by glebius). · Explain WhyMay 12 2022, 8:23 PM

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG08f17d143289: unix: make unp_connect2() void.

Revision Contents
Changeset List

Path

Size

sys/

kern/

uipc_usrreq.c

19 lines

Diff 105903

View Options

unix: make unp_connect2() voidClosedPublicActions