Drop d_dump from struct cdevsw
ClosedPublic
Actions

Authored by mhorne on May 11 2022, 3:10 PM.

Tags

None

Referenced Files

	F163143695: D35172.id105859.diff
	Mon, Jul 20, 12:05 PM

	Unknown Object (File)
	Sat, Jul 18, 6:18 PM

	Unknown Object (File)
	Sat, Jul 18, 3:35 AM

	Unknown Object (File)
	Mon, Jul 6, 4:49 AM

	Unknown Object (File)
	Jun 18 2026, 8:41 PM

	Unknown Object (File)
	Jun 13 2026, 3:05 AM

	Unknown Object (File)
	Jun 9 2026, 12:35 PM

	Unknown Object (File)
	May 23 2026, 10:22 AM

View All Files

Subscribers

None

Details

Reviewers

markj
imp
jhb

Commits

rG6350ace614fc: Drop d_dump from struct cdevsw
rG0f50da2e09b7: Drop d_dump from struct cdevsw

Summary

It appears to be unused. These days struct disk has a d_dump member,
which is what gets passed to the kernel dump framework.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45529
Build 42417: arc lint + arc unit

Event Timeline

mhorne requested review of this revision.May 11 2022, 3:10 PM

mhorne created this revision.

Harbormaster completed remote builds in B45528: Diff 105858.May 11 2022, 3:10 PM

Fix a typo: void ** -> void *

Harbormaster completed remote builds in B45529: Diff 105859.May 11 2022, 3:13 PM

markj accepted this revision.May 12 2022, 1:00 PM

This revision is now accepted and ready to land.May 12 2022, 1:00 PM

Closed by commit rG0f50da2e09b7: Drop d_dump from struct cdevsw (authored by mhorne). · Explain WhyMay 13 2022, 1:45 PM

This revision was automatically updated to reflect the committed changes.

mhorne added a commit: rG0f50da2e09b7: Drop d_dump from struct cdevsw.

mhorne added a commit: rG6350ace614fc: Drop d_dump from struct cdevsw.May 27 2022, 4:24 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

kern_conf.c

7 lines

sys/

conf.h

8 lines

Diff 105859

View Options

sys/kern/kern_conf.c