Page MenuHomeFreeBSD
Differential D35052

LinuxKPI: Switch irq_work implementation back to standard taskqueue
ClosedPublic
Actions

Authored by wulf on Apr 24 2022, 11:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 6, 5:05 AM
Unknown Object (File)
Wed, Jun 17, 5:23 PM
Unknown Object (File)
Wed, Jun 17, 5:10 PM
Unknown Object (File)
Wed, Jun 17, 2:46 AM
Unknown Object (File)
Tue, Jun 16, 3:47 AM
Unknown Object (File)
Wed, Jun 10, 10:26 AM
Unknown Object (File)
Jun 3 2026, 4:07 PM
Unknown Object (File)
Apr 23 2026, 6:01 PM
View All Files
Subscribers
emaste
imp
linuxkpi

Details

Reviewers
• hselasky
manu
Commits
rG185159f77c9c: LinuxKPI: Switch irq_work implementation back to standard taskqueue
rG42c04803d28e: LinuxKPI: Do not use forward declaration for struct llist_node
rGa3e1754f45bf: LinuxKPI: IRQ work add TASKQUEUE_FAIL_IF_PENDING flag to taskqueue_enqueue
rG71fe907dfb03: LinuxKPI: Switch irq_work implementation back to standard taskqueue
rGbec4576e4c19: LinuxKPI: Do not use forward declaration for struct llist_node
rGfa30bff5da31: LinuxKPI: IRQ work add TASKQUEUE_FAIL_IF_PENDING flag to taskqueue_enqueue
Summary

from fast one as dmabuf does not run callbacks from critical sections
since drm-kmod 5.7.
Consumers which requires fair irq_work like drm-kmod 5.4 must #define
LKPI_IRQ_WORK_USE_FAST_TQ somewhere in source file before linux/irq_work.h
inclusion to enable old behavior.

While here include linux/llist.h to get struct llist_node definition
and add TQFLG_FAILIF_PENDING flag to taskqueue_enqueue to match Linux.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45352
Build 42240: arc lint + arc unit

Event Timeline

wulf created this revision.Apr 24 2022, 11:42 PM
Herald added subscribers: linuxkpi, emaste, imp. · View Herald TranscriptApr 24 2022, 11:42 PM
wulf requested review of this revision.Apr 24 2022, 11:42 PM
Harbormaster completed remote builds in B45352: Diff 105384.Apr 24 2022, 11:42 PM
wulf updated this revision to Diff 105412.Apr 25 2022, 8:40 PM

Chase for taskqueue_enqueue flag name change

Harbormaster completed remote builds in B45365: Diff 105412.Apr 25 2022, 8:40 PM
wulf added a comment.Apr 25 2022, 8:41 PM

TQFLG_FAILIF_PENDING -> TASKQUEUE_FAIL_IF_PENDING

This revision was not accepted when it landed; it landed in state Needs Review.May 17 2022, 12:12 PM
Closed by commit rGfa30bff5da31: LinuxKPI: IRQ work add TASKQUEUE_FAIL_IF_PENDING flag to taskqueue_enqueue (authored by wulf). · Explain Why
This revision was automatically updated to reflect the committed changes.
wulf added a commit: rGfa30bff5da31: LinuxKPI: IRQ work add TASKQUEUE_FAIL_IF_PENDING flag to taskqueue_enqueue.
wulf added a commit: rGbec4576e4c19: LinuxKPI: Do not use forward declaration for struct llist_node.
wulf added a commit: rG71fe907dfb03: LinuxKPI: Switch irq_work implementation back to standard taskqueue.
wulf added a commit: rGa3e1754f45bf: LinuxKPI: IRQ work add TASKQUEUE_FAIL_IF_PENDING flag to taskqueue_enqueue.Jun 1 2022, 9:52 PM
wulf added a commit: rG42c04803d28e: LinuxKPI: Do not use forward declaration for struct llist_node.
wulf added a commit: rG185159f77c9c: LinuxKPI: Switch irq_work implementation back to standard taskqueue.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
21 lines

Diff 105384

View Options

sys/compat/linuxkpi/common/include/linux/irq_work.h

Loading...