Page MenuHomeFreeBSD
Differential D4283

mlx4/mlxen: update version to 2.1.6
ClosedPublic
Actions

Authored by markb_mellanox.com on Nov 26 2015, 12:19 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 15, 5:22 PM
Unknown Object (File)
Mon, Apr 14, 6:18 AM
Unknown Object (File)
Mon, Apr 14, 3:10 AM
Unknown Object (File)
Mon, Apr 14, 1:40 AM
Unknown Object (File)
Sun, Apr 13, 9:12 PM
Unknown Object (File)
Wed, Apr 9, 5:21 PM
Unknown Object (File)
Jan 31 2025, 4:58 AM
Unknown Object (File)
Jan 25 2025, 2:14 PM
View All 83 Files
Subscribers
gnn
• hselasky
imp

Details

Reviewers
• hselasky
Group Reviewers
network
Commits
rS291694: Updated the mlx4 and mlxen drivers to the latest version, v2.1.6:
Summary

Update code base to latest version.

Sponsored by: Mellanox Technologies
Signed-off-by: Mark Bloch <markb@mellanox.com>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

markb_mellanox.com updated this revision to Diff 10513.Nov 26 2015, 12:19 PM
markb_mellanox.com retitled this revision from to mlx4/mlxen: update version to 2.1.6.
markb_mellanox.com updated this object.
markb_mellanox.com edited the test plan for this revision. (Show Details)
markb_mellanox.com added a reviewer: • hselasky.
markb_mellanox.com set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptNov 26 2015, 12:19 PM
markb_mellanox.com added a child revision: D4284: mlxen: add busdma support.Nov 26 2015, 12:21 PM
markb_mellanox.com updated this object.Nov 26 2015, 12:23 PM
• hselasky edited edge metadata.Nov 26 2015, 12:56 PM

utils.c is already in kern/uipc_mbufhash.c see m_ether_tcpip_hash() .

• hselasky edited edge metadata.Nov 26 2015, 12:59 PM
• hselasky added a subscriber: • hselasky.
markb_mellanox.com added a comment.Nov 26 2015, 1:17 PM
In D4283#90260, @hselasky wrote:

utils.c is already in kern/uipc_mbufhash.c see m_ether_tcpip_hash() .

On 11, but on 10 we still don't have it.
There is a compile time check (in the Makefile) if to build uitls.{c,h} or not.

Seeing as we want to MFC it at some point, it will be easier this way.

sbruno added a subscriber: gnn.Dec 1 2015, 9:16 PM
markb_mellanox.com added a reviewer: network.Dec 2 2015, 11:53 AM
• hselasky accepted this revision.Dec 3 2015, 10:45 AM
• hselasky edited edge metadata.

I see some whitespace and other minor style issues I'll fix before committing. Looks good.

This revision is now accepted and ready to land.Dec 3 2015, 10:45 AM
Closed by commit rS291694: Updated the mlx4 and mlxen drivers to the latest version, v2.1.6: (authored by • hselasky). · Explain WhyDec 3 2015, 1:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
include/
linux/
35 lines
modules/
mlx4/
19 lines
mlxen/
19 lines
ofed/
drivers/
net/
mlx4/
15 lines
275 lines
16 lines
27 lines
63 lines
84 lines
10 lines
20 lines
1 line
7 lines
44 lines
189 lines
include/
linux/
mlx4/
2 lines
7 lines
8 lines

Diff 10513

View Options

sys/compat/linuxkpi/common/include/linux/compat.h

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines object = vm_object_allocate_dyn(tmpfs_pager_type, size,
OBJ_COLORED | OBJ_SWAP); OBJ_COLORED | OBJ_SWAP);
if (!swap_pager_init_object(object, NULL, NULL, size, 0)) { if (!swap_pager_init_object(object, NULL, NULL, size, 0)) {
vm_object_deallocate(object); vm_object_deallocate(object);
object = NULL; object = NULL;
} }
return (object); return (object);
} }
/*
* Make sure tmpfs vnodes with writable mappings can be found on the lazy list.
*
* This allows for periodic mtime updates while only scanning vnodes which are
* plausibly dirty, see tmpfs_update_mtime_lazy.
*/
static void static void
tmpfs_pager_writecount_recalc(vm_object_t object, vm_offset_t old,
vm_offset_t new)
{
struct vnode *vp;
VM_OBJECT_ASSERT_WLOCKED(object);
vp = object->un_pager.swp.swp_tmpfs;
/*
* Forced unmount?
*/
if (vp == NULL) {
KASSERT((object->flags & OBJ_TMPFS_VREF) == 0,
("object %p with OBJ_TMPFS_VREF but without vnode", object));
VM_OBJECT_WUNLOCK(object);
return;
}
if (old == 0) {
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
("object without writtable mappings has a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
- ("object without writtable mappings has a reference"));
+ ("object without writable mappings has a reference"));
VNPASS(vp->v_usecount > 0, vp);
markj:
VNPASS(vp->v_usecount > 0, vp);
} else {
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
("object with writtable mappings does not have a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
- ("object with writtable mappings does not have a reference"));
+ ("object with writable mappings does not have a reference"));
}
if (old == new) {
markj:
mjgAuthorUnsubmitted
Done
Inline Actions

fixed locally

mjg: fixed locally
}
if (old == new) {
VM_OBJECT_WUNLOCK(object);
return;
}
if (new == 0) {
vm_object_clear_flag(object, OBJ_TMPFS_VREF);
VM_OBJECT_WUNLOCK(object);
vrele(vp);
} else {
if ((object->flags & OBJ_TMPFS_VREF) == 0) {
vref(vp);
vlazy(vp);
vm_object_set_flag(object, OBJ_TMPFS_VREF);
}
VM_OBJECT_WUNLOCK(object);
}
}
static void
tmpfs_pager_update_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
mjgAuthorUnsubmitted
Done
Inline Actions

I don't know if this assert is of any use, cargo culted this bit from the original swap pager.

mjg: I don't know if this assert is of any use, cargo culted this bit from the original swap pager.
kibUnsubmitted
Not Done
Inline Actions

It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'

kib: It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings += (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_release_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings -= (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp) tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
{ {
struct vnode *vp; struct vnode *vp;
/* /*
* Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type * Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type
* type, but not OBJ_TMPFS flag. In this case there is no * type, but not OBJ_TMPFS flag. In this case there is no
* v_writecount to adjust. * v_writecount to adjust.
Show All 15 Linestmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
if (vp_heldp != NULL) if (vp_heldp != NULL)
VM_OBJECT_RUNLOCK(object); VM_OBJECT_RUNLOCK(object);
} }
struct pagerops tmpfs_pager_ops = { struct pagerops tmpfs_pager_ops = {
.pgo_kvme_type = KVME_TYPE_VNODE, .pgo_kvme_type = KVME_TYPE_VNODE,
.pgo_alloc = tmpfs_pager_alloc, .pgo_alloc = tmpfs_pager_alloc,
.pgo_set_writeable_dirty = vm_object_set_writeable_dirty_, .pgo_set_writeable_dirty = vm_object_set_writeable_dirty_,
.pgo_update_writecount = tmpfs_pager_update_writecount,
.pgo_release_writecount = tmpfs_pager_release_writecount,
.pgo_mightbedirty = vm_object_mightbedirty_, .pgo_mightbedirty = vm_object_mightbedirty_,
.pgo_getvp = tmpfs_pager_getvp, .pgo_getvp = tmpfs_pager_getvp,
}; };
static int static int
tmpfs_node_ctor(void *mem, int size, void *arg, int flags) tmpfs_node_ctor(void *mem, int size, void *arg, int flags)
{ {
struct tmpfs_node *node; struct tmpfs_node *node;
▲ Show 20 Lines • Show All 496 Lines • ▼ Show 20 Linestmpfs_free_dirent(struct tmpfs_mount *tmp, struct tmpfs_dirent *de)
if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL) if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL)
free(de->ud.td_name, M_TMPFSNAME); free(de->ud.td_name, M_TMPFSNAME);
free(de, M_TMPFSDIR); free(de, M_TMPFSDIR);
} }
void void
tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj) tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj)
{ {
bool want_vrele;
ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject"); ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject");
if (vp->v_type != VREG || obj == NULL) if (vp->v_type != VREG || obj == NULL)
return; return;
VM_OBJECT_WLOCK(obj); VM_OBJECT_WLOCK(obj);
VI_LOCK(vp); VI_LOCK(vp);
/*
* May be going through forced unmount.
*/
want_vrele = false;
if ((obj->flags & OBJ_TMPFS_VREF) != 0) {
vm_object_clear_flag(obj, OBJ_TMPFS_VREF);
want_vrele = true;
}
kibUnsubmitted
Not Done
Inline Actions

There should be a blank line after the last line of the text where the multi-line comment applies.

kib: There should be a blank line after the last line of the text where the multi-line comment…
vm_object_clear_flag(obj, OBJ_TMPFS); vm_object_clear_flag(obj, OBJ_TMPFS);
obj->un_pager.swp.swp_tmpfs = NULL; obj->un_pager.swp.swp_tmpfs = NULL;
if (vp->v_writecount < 0) if (vp->v_writecount < 0)
vp->v_writecount = 0; vp->v_writecount = 0;
VI_UNLOCK(vp); VI_UNLOCK(vp);
VM_OBJECT_WUNLOCK(obj); VM_OBJECT_WUNLOCK(obj);
if (want_vrele) {
vrele(vp);
}
} }
/* /*
* Need to clear v_object for insmntque failure. * Need to clear v_object for insmntque failure.
*/ */
static void static void
tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg) tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg)
{ {
▲ Show 20 Lines • Show All 1,397 Lines • Show Last 20 Lines
View Options

sys/modules/mlx4/Makefile

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines object = vm_object_allocate_dyn(tmpfs_pager_type, size,
OBJ_COLORED | OBJ_SWAP); OBJ_COLORED | OBJ_SWAP);
if (!swap_pager_init_object(object, NULL, NULL, size, 0)) { if (!swap_pager_init_object(object, NULL, NULL, size, 0)) {
vm_object_deallocate(object); vm_object_deallocate(object);
object = NULL; object = NULL;
} }
return (object); return (object);
} }
/*
* Make sure tmpfs vnodes with writable mappings can be found on the lazy list.
*
* This allows for periodic mtime updates while only scanning vnodes which are
* plausibly dirty, see tmpfs_update_mtime_lazy.
*/
static void static void
tmpfs_pager_writecount_recalc(vm_object_t object, vm_offset_t old,
vm_offset_t new)
{
struct vnode *vp;
VM_OBJECT_ASSERT_WLOCKED(object);
vp = object->un_pager.swp.swp_tmpfs;
/*
* Forced unmount?
*/
if (vp == NULL) {
KASSERT((object->flags & OBJ_TMPFS_VREF) == 0,
("object %p with OBJ_TMPFS_VREF but without vnode", object));
VM_OBJECT_WUNLOCK(object);
return;
}
if (old == 0) {
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
("object without writtable mappings has a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
- ("object without writtable mappings has a reference"));
+ ("object without writable mappings has a reference"));
VNPASS(vp->v_usecount > 0, vp);
markj:
VNPASS(vp->v_usecount > 0, vp);
} else {
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
("object with writtable mappings does not have a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
- ("object with writtable mappings does not have a reference"));
+ ("object with writable mappings does not have a reference"));
}
if (old == new) {
markj:
mjgAuthorUnsubmitted
Done
Inline Actions

fixed locally

mjg: fixed locally
}
if (old == new) {
VM_OBJECT_WUNLOCK(object);
return;
}
if (new == 0) {
vm_object_clear_flag(object, OBJ_TMPFS_VREF);
VM_OBJECT_WUNLOCK(object);
vrele(vp);
} else {
if ((object->flags & OBJ_TMPFS_VREF) == 0) {
vref(vp);
vlazy(vp);
vm_object_set_flag(object, OBJ_TMPFS_VREF);
}
VM_OBJECT_WUNLOCK(object);
}
}
static void
tmpfs_pager_update_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
mjgAuthorUnsubmitted
Done
Inline Actions

I don't know if this assert is of any use, cargo culted this bit from the original swap pager.

mjg: I don't know if this assert is of any use, cargo culted this bit from the original swap pager.
kibUnsubmitted
Not Done
Inline Actions

It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'

kib: It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings += (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_release_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings -= (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp) tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
{ {
struct vnode *vp; struct vnode *vp;
/* /*
* Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type * Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type
* type, but not OBJ_TMPFS flag. In this case there is no * type, but not OBJ_TMPFS flag. In this case there is no
* v_writecount to adjust. * v_writecount to adjust.
Show All 15 Linestmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
if (vp_heldp != NULL) if (vp_heldp != NULL)
VM_OBJECT_RUNLOCK(object); VM_OBJECT_RUNLOCK(object);
} }
struct pagerops tmpfs_pager_ops = { struct pagerops tmpfs_pager_ops = {
.pgo_kvme_type = KVME_TYPE_VNODE, .pgo_kvme_type = KVME_TYPE_VNODE,
.pgo_alloc = tmpfs_pager_alloc, .pgo_alloc = tmpfs_pager_alloc,
.pgo_set_writeable_dirty = vm_object_set_writeable_dirty_, .pgo_set_writeable_dirty = vm_object_set_writeable_dirty_,
.pgo_update_writecount = tmpfs_pager_update_writecount,
.pgo_release_writecount = tmpfs_pager_release_writecount,
.pgo_mightbedirty = vm_object_mightbedirty_, .pgo_mightbedirty = vm_object_mightbedirty_,
.pgo_getvp = tmpfs_pager_getvp, .pgo_getvp = tmpfs_pager_getvp,
}; };
static int static int
tmpfs_node_ctor(void *mem, int size, void *arg, int flags) tmpfs_node_ctor(void *mem, int size, void *arg, int flags)
{ {
struct tmpfs_node *node; struct tmpfs_node *node;
▲ Show 20 Lines • Show All 496 Lines • ▼ Show 20 Linestmpfs_free_dirent(struct tmpfs_mount *tmp, struct tmpfs_dirent *de)
if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL) if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL)
free(de->ud.td_name, M_TMPFSNAME); free(de->ud.td_name, M_TMPFSNAME);
free(de, M_TMPFSDIR); free(de, M_TMPFSDIR);
} }
void void
tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj) tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj)
{ {
bool want_vrele;
ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject"); ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject");
if (vp->v_type != VREG || obj == NULL) if (vp->v_type != VREG || obj == NULL)
return; return;
VM_OBJECT_WLOCK(obj); VM_OBJECT_WLOCK(obj);
VI_LOCK(vp); VI_LOCK(vp);
/*
* May be going through forced unmount.
*/
want_vrele = false;
if ((obj->flags & OBJ_TMPFS_VREF) != 0) {
vm_object_clear_flag(obj, OBJ_TMPFS_VREF);
want_vrele = true;
}
kibUnsubmitted
Not Done
Inline Actions

There should be a blank line after the last line of the text where the multi-line comment applies.

kib: There should be a blank line after the last line of the text where the multi-line comment…
vm_object_clear_flag(obj, OBJ_TMPFS); vm_object_clear_flag(obj, OBJ_TMPFS);
obj->un_pager.swp.swp_tmpfs = NULL; obj->un_pager.swp.swp_tmpfs = NULL;
if (vp->v_writecount < 0) if (vp->v_writecount < 0)
vp->v_writecount = 0; vp->v_writecount = 0;
VI_UNLOCK(vp); VI_UNLOCK(vp);
VM_OBJECT_WUNLOCK(obj); VM_OBJECT_WUNLOCK(obj);
if (want_vrele) {
vrele(vp);
}
} }
/* /*
* Need to clear v_object for insmntque failure. * Need to clear v_object for insmntque failure.
*/ */
static void static void
tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg) tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg)
{ {
▲ Show 20 Lines • Show All 1,397 Lines • Show Last 20 Lines
View Options

sys/modules/mlxen/Makefile

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines object = vm_object_allocate_dyn(tmpfs_pager_type, size,
OBJ_COLORED | OBJ_SWAP); OBJ_COLORED | OBJ_SWAP);
if (!swap_pager_init_object(object, NULL, NULL, size, 0)) { if (!swap_pager_init_object(object, NULL, NULL, size, 0)) {
vm_object_deallocate(object); vm_object_deallocate(object);
object = NULL; object = NULL;
} }
return (object); return (object);
} }
/*
* Make sure tmpfs vnodes with writable mappings can be found on the lazy list.
*
* This allows for periodic mtime updates while only scanning vnodes which are
* plausibly dirty, see tmpfs_update_mtime_lazy.
*/
static void static void
tmpfs_pager_writecount_recalc(vm_object_t object, vm_offset_t old,
vm_offset_t new)
{
struct vnode *vp;
VM_OBJECT_ASSERT_WLOCKED(object);
vp = object->un_pager.swp.swp_tmpfs;
/*
* Forced unmount?
*/
if (vp == NULL) {
KASSERT((object->flags & OBJ_TMPFS_VREF) == 0,
("object %p with OBJ_TMPFS_VREF but without vnode", object));
VM_OBJECT_WUNLOCK(object);
return;
}
if (old == 0) {
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
("object without writtable mappings has a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
- ("object without writtable mappings has a reference"));
+ ("object without writable mappings has a reference"));
VNPASS(vp->v_usecount > 0, vp);
markj:
VNPASS(vp->v_usecount > 0, vp);
} else {
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
("object with writtable mappings does not have a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
- ("object with writtable mappings does not have a reference"));
+ ("object with writable mappings does not have a reference"));
}
if (old == new) {
markj:
mjgAuthorUnsubmitted
Done
Inline Actions

fixed locally

mjg: fixed locally
}
if (old == new) {
VM_OBJECT_WUNLOCK(object);
return;
}
if (new == 0) {
vm_object_clear_flag(object, OBJ_TMPFS_VREF);
VM_OBJECT_WUNLOCK(object);
vrele(vp);
} else {
if ((object->flags & OBJ_TMPFS_VREF) == 0) {
vref(vp);
vlazy(vp);
vm_object_set_flag(object, OBJ_TMPFS_VREF);
}
VM_OBJECT_WUNLOCK(object);
}
}
static void
tmpfs_pager_update_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
mjgAuthorUnsubmitted
Done
Inline Actions

I don't know if this assert is of any use, cargo culted this bit from the original swap pager.

mjg: I don't know if this assert is of any use, cargo culted this bit from the original swap pager.
kibUnsubmitted
Not Done
Inline Actions

It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'

kib: It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings += (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_release_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings -= (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp) tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
{ {
struct vnode *vp; struct vnode *vp;
/* /*
* Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type * Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type
* type, but not OBJ_TMPFS flag. In this case there is no * type, but not OBJ_TMPFS flag. In this case there is no
* v_writecount to adjust. * v_writecount to adjust.
Show All 15 Linestmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
if (vp_heldp != NULL) if (vp_heldp != NULL)
VM_OBJECT_RUNLOCK(object); VM_OBJECT_RUNLOCK(object);
} }
struct pagerops tmpfs_pager_ops = { struct pagerops tmpfs_pager_ops = {
.pgo_kvme_type = KVME_TYPE_VNODE, .pgo_kvme_type = KVME_TYPE_VNODE,
.pgo_alloc = tmpfs_pager_alloc, .pgo_alloc = tmpfs_pager_alloc,
.pgo_set_writeable_dirty = vm_object_set_writeable_dirty_, .pgo_set_writeable_dirty = vm_object_set_writeable_dirty_,
.pgo_update_writecount = tmpfs_pager_update_writecount,
.pgo_release_writecount = tmpfs_pager_release_writecount,
.pgo_mightbedirty = vm_object_mightbedirty_, .pgo_mightbedirty = vm_object_mightbedirty_,
.pgo_getvp = tmpfs_pager_getvp, .pgo_getvp = tmpfs_pager_getvp,
}; };
static int static int
tmpfs_node_ctor(void *mem, int size, void *arg, int flags) tmpfs_node_ctor(void *mem, int size, void *arg, int flags)
{ {
struct tmpfs_node *node; struct tmpfs_node *node;
▲ Show 20 Lines • Show All 496 Lines • ▼ Show 20 Linestmpfs_free_dirent(struct tmpfs_mount *tmp, struct tmpfs_dirent *de)
if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL) if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL)
free(de->ud.td_name, M_TMPFSNAME); free(de->ud.td_name, M_TMPFSNAME);
free(de, M_TMPFSDIR); free(de, M_TMPFSDIR);
} }
void void
tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj) tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj)
{ {
bool want_vrele;
ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject"); ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject");
if (vp->v_type != VREG || obj == NULL) if (vp->v_type != VREG || obj == NULL)
return; return;
VM_OBJECT_WLOCK(obj); VM_OBJECT_WLOCK(obj);
VI_LOCK(vp); VI_LOCK(vp);
/*
* May be going through forced unmount.
*/
want_vrele = false;
if ((obj->flags & OBJ_TMPFS_VREF) != 0) {
vm_object_clear_flag(obj, OBJ_TMPFS_VREF);
want_vrele = true;
}
kibUnsubmitted
Not Done
Inline Actions

There should be a blank line after the last line of the text where the multi-line comment applies.

kib: There should be a blank line after the last line of the text where the multi-line comment…
vm_object_clear_flag(obj, OBJ_TMPFS); vm_object_clear_flag(obj, OBJ_TMPFS);
obj->un_pager.swp.swp_tmpfs = NULL; obj->un_pager.swp.swp_tmpfs = NULL;
if (vp->v_writecount < 0) if (vp->v_writecount < 0)
vp->v_writecount = 0; vp->v_writecount = 0;
VI_UNLOCK(vp); VI_UNLOCK(vp);
VM_OBJECT_WUNLOCK(obj); VM_OBJECT_WUNLOCK(obj);
if (want_vrele) {
vrele(vp);
}
} }
/* /*
* Need to clear v_object for insmntque failure. * Need to clear v_object for insmntque failure.
*/ */
static void static void
tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg) tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg)
{ {
▲ Show 20 Lines • Show All 1,397 Lines • Show Last 20 Lines
View Options

sys/ofed/drivers/net/mlx4/en_ethtool.c

Show First 20 Lines • Show All 93 Lines • ▼ Show 20 Lines object = vm_object_allocate_dyn(tmpfs_pager_type, size,
OBJ_COLORED | OBJ_SWAP); OBJ_COLORED | OBJ_SWAP);
if (!swap_pager_init_object(object, NULL, NULL, size, 0)) { if (!swap_pager_init_object(object, NULL, NULL, size, 0)) {
vm_object_deallocate(object); vm_object_deallocate(object);
object = NULL; object = NULL;
} }
return (object); return (object);
} }
/*
* Make sure tmpfs vnodes with writable mappings can be found on the lazy list.
*
* This allows for periodic mtime updates while only scanning vnodes which are
* plausibly dirty, see tmpfs_update_mtime_lazy.
*/
static void static void
tmpfs_pager_writecount_recalc(vm_object_t object, vm_offset_t old,
vm_offset_t new)
{
struct vnode *vp;
VM_OBJECT_ASSERT_WLOCKED(object);
vp = object->un_pager.swp.swp_tmpfs;
/*
* Forced unmount?
*/
if (vp == NULL) {
KASSERT((object->flags & OBJ_TMPFS_VREF) == 0,
("object %p with OBJ_TMPFS_VREF but without vnode", object));
VM_OBJECT_WUNLOCK(object);
return;
}
if (old == 0) {
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
("object without writtable mappings has a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) == 0, vp,
- ("object without writtable mappings has a reference"));
+ ("object without writable mappings has a reference"));
VNPASS(vp->v_usecount > 0, vp);
markj:
VNPASS(vp->v_usecount > 0, vp);
} else {
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
("object with writtable mappings does not have a reference"));
markjUnsubmitted
Not Done
Inline Actions
VNASSERT((object->flags & OBJ_TMPFS_VREF) != 0, vp,
- ("object with writtable mappings does not have a reference"));
+ ("object with writable mappings does not have a reference"));
}
if (old == new) {
markj:
mjgAuthorUnsubmitted
Done
Inline Actions

fixed locally

mjg: fixed locally
}
if (old == new) {
VM_OBJECT_WUNLOCK(object);
return;
}
if (new == 0) {
vm_object_clear_flag(object, OBJ_TMPFS_VREF);
VM_OBJECT_WUNLOCK(object);
vrele(vp);
} else {
if ((object->flags & OBJ_TMPFS_VREF) == 0) {
vref(vp);
vlazy(vp);
vm_object_set_flag(object, OBJ_TMPFS_VREF);
}
VM_OBJECT_WUNLOCK(object);
}
}
static void
tmpfs_pager_update_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
mjgAuthorUnsubmitted
Done
Inline Actions

I don't know if this assert is of any use, cargo culted this bit from the original swap pager.

mjg: I don't know if this assert is of any use, cargo culted this bit from the original swap pager.
kibUnsubmitted
Not Done
Inline Actions

It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'

kib: It does make sense, but perhaps replace the word 'Splittable' with 'tmpfs vm'
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings += (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_release_writecount(vm_object_t object, vm_offset_t start,
vm_offset_t end)
{
vm_offset_t new, old;
VM_OBJECT_WLOCK(object);
KASSERT((object->flags & OBJ_ANON) == 0,
("Splittable object with writecount"));
old = object->un_pager.swp.writemappings;
object->un_pager.swp.writemappings -= (vm_ooffset_t)end - start;
new = object->un_pager.swp.writemappings;
tmpfs_pager_writecount_recalc(object, old, new);
VM_OBJECT_ASSERT_UNLOCKED(object);
}
static void
tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp) tmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
{ {
struct vnode *vp; struct vnode *vp;
/* /*
* Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type * Tmpfs VREG node, which was reclaimed, has tmpfs_pager_type
* type, but not OBJ_TMPFS flag. In this case there is no * type, but not OBJ_TMPFS flag. In this case there is no
* v_writecount to adjust. * v_writecount to adjust.
Show All 15 Linestmpfs_pager_getvp(vm_object_t object, struct vnode **vpp, bool *vp_heldp)
if (vp_heldp != NULL) if (vp_heldp != NULL)
VM_OBJECT_RUNLOCK(object); VM_OBJECT_RUNLOCK(object);
} }
struct pagerops tmpfs_pager_ops = { struct pagerops tmpfs_pager_ops = {
.pgo_kvme_type = KVME_TYPE_VNODE, .pgo_kvme_type = KVME_TYPE_VNODE,
.pgo_alloc = tmpfs_pager_alloc, .pgo_alloc = tmpfs_pager_alloc,
.pgo_set_writeable_dirty = vm_object_set_writeable_dirty_, .pgo_set_writeable_dirty = vm_object_set_writeable_dirty_,
.pgo_update_writecount = tmpfs_pager_update_writecount,
.pgo_release_writecount = tmpfs_pager_release_writecount,
.pgo_mightbedirty = vm_object_mightbedirty_, .pgo_mightbedirty = vm_object_mightbedirty_,
.pgo_getvp = tmpfs_pager_getvp, .pgo_getvp = tmpfs_pager_getvp,
}; };
static int static int
tmpfs_node_ctor(void *mem, int size, void *arg, int flags) tmpfs_node_ctor(void *mem, int size, void *arg, int flags)
{ {
struct tmpfs_node *node; struct tmpfs_node *node;
▲ Show 20 Lines • Show All 496 Lines • ▼ Show 20 Linestmpfs_free_dirent(struct tmpfs_mount *tmp, struct tmpfs_dirent *de)
if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL) if (!tmpfs_dirent_duphead(de) && de->ud.td_name != NULL)
free(de->ud.td_name, M_TMPFSNAME); free(de->ud.td_name, M_TMPFSNAME);
free(de, M_TMPFSDIR); free(de, M_TMPFSDIR);
} }
void void
tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj) tmpfs_destroy_vobject(struct vnode *vp, vm_object_t obj)
{ {
bool want_vrele;
ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject"); ASSERT_VOP_ELOCKED(vp, "tmpfs_destroy_vobject");
if (vp->v_type != VREG || obj == NULL) if (vp->v_type != VREG || obj == NULL)
return; return;
VM_OBJECT_WLOCK(obj); VM_OBJECT_WLOCK(obj);
VI_LOCK(vp); VI_LOCK(vp);
/*
* May be going through forced unmount.
*/
want_vrele = false;
if ((obj->flags & OBJ_TMPFS_VREF) != 0) {
vm_object_clear_flag(obj, OBJ_TMPFS_VREF);
want_vrele = true;
}
kibUnsubmitted
Not Done
Inline Actions

There should be a blank line after the last line of the text where the multi-line comment applies.

kib: There should be a blank line after the last line of the text where the multi-line comment…
vm_object_clear_flag(obj, OBJ_TMPFS); vm_object_clear_flag(obj, OBJ_TMPFS);
obj->un_pager.swp.swp_tmpfs = NULL; obj->un_pager.swp.swp_tmpfs = NULL;
if (vp->v_writecount < 0) if (vp->v_writecount < 0)
vp->v_writecount = 0; vp->v_writecount = 0;
VI_UNLOCK(vp); VI_UNLOCK(vp);
VM_OBJECT_WUNLOCK(obj); VM_OBJECT_WUNLOCK(obj);
if (want_vrele) {
vrele(vp);
}
} }
/* /*
* Need to clear v_object for insmntque failure. * Need to clear v_object for insmntque failure.
*/ */
static void static void
tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg) tmpfs_insmntque_dtr(struct vnode *vp, void *dtr_arg)
{ {
▲ Show 20 Lines • Show All 1,397 Lines • Show Last 20 Lines
View Options

sys/ofed/drivers/net/mlx4/en_main.c

Loading...
View Options

sys/ofed/drivers/net/mlx4/en_netdev.c

Loading...
View Options

sys/ofed/drivers/net/mlx4/en_port.c

Loading...
View Options

sys/ofed/drivers/net/mlx4/en_rx.c

Loading...
View Options

sys/ofed/drivers/net/mlx4/en_selftest.c

Loading...
View Options

sys/ofed/drivers/net/mlx4/en_tx.c

Loading...
View Options

sys/ofed/drivers/net/mlx4/main.c

Loading...
View Options

sys/ofed/drivers/net/mlx4/mlx4.h

Loading...
View Options

sys/ofed/drivers/net/mlx4/mlx4_en.h

Loading...
View Options

sys/ofed/drivers/net/mlx4/mlx4_stats.h

Loading...
View Options

sys/ofed/drivers/net/mlx4/port.c

Loading...
View Options

sys/ofed/drivers/net/mlx4/utils.h

Loading...
View Options

sys/ofed/drivers/net/mlx4/utils.c

Loading...
View Options

sys/ofed/include/linux/mlx4/cq.h

Loading...
View Options

sys/ofed/include/linux/mlx4/device.h

Loading...
View Options

sys/ofed/include/linux/mlx4/qp.h

Loading...