libsysdecode: Include required headers in sysdecode.h
ClosedPublic
Actions

Authored by markj on Apr 13 2022, 2:34 PM.

Details

Reviewers

jhb
imp
emaste
pauamma_chezdork.com

Group Reviewers

manpages

Commits

rG354efc4c9407: libsysdecode: Include required headers in sysdecode.h

Summary

It seems a bit silly to force all consumers to include several system
headers any time they include sysdecode.h. There has been a trend in
FreeBSD to make headers more self-contained, so let's apply that here.
No functional change intended.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 45145
Build 42033: arc lint + arc unit

Event Timeline

markj created this revision.Apr 13 2022, 2:34 PM

Herald added a reviewer: manpages. · View Herald TranscriptApr 13 2022, 2:34 PM

markj requested review of this revision.Apr 13 2022, 2:34 PM

Harbormaster completed remote builds in B45145: Diff 104960.Apr 13 2022, 2:34 PM

Sounds good to me

This revision is now accepted and ready to land.Apr 13 2022, 2:37 PM

Manual page changes appear consistent with addition to sysdecode.h. (Naive question: does always including stdio.h cause any noticeable bloat?)

In D34899#791172, @pauamma_gundo.com wrote:

(Naive question: does always including stdio.h cause any noticeable bloat?)

I'm not sure what you mean by bloat. The only negative effect of this is that a consumers which already includes stdio.h will force the C preprocessor to read the file again. This has no impact on the compiled code but forces the C preprocessor to read the file again.

jhb accepted this revision.Apr 14 2022, 10:46 PM

Closed by commit rG354efc4c9407: libsysdecode: Include required headers in sysdecode.h (authored by markj). · Explain WhyApr 15 2022, 2:28 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG354efc4c9407: libsysdecode: Include required headers in sysdecode.h.