Page MenuHomeFreeBSD

libsysdecode: Include required headers in sysdecode.h
ClosedPublic

Authored by markj on Apr 13 2022, 2:34 PM.
Tags
None
Referenced Files
F157344793: D34899.diff
Wed, May 20, 12:08 PM
Unknown Object (File)
Mon, May 4, 2:40 PM
Unknown Object (File)
Tue, Apr 28, 8:27 PM
Unknown Object (File)
Tue, Apr 28, 8:24 PM
Unknown Object (File)
Mon, Apr 27, 9:11 PM
Unknown Object (File)
Sun, Apr 26, 4:07 AM
Unknown Object (File)
Tue, Apr 21, 1:59 PM
Unknown Object (File)
Apr 11 2026, 12:36 AM

Details

Summary

It seems a bit silly to force all consumers to include several system
headers any time they include sysdecode.h. There has been a trend in
FreeBSD to make headers more self-contained, so let's apply that here.
No functional change intended.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 45145
Build 42033: arc lint + arc unit

Event Timeline

markj requested review of this revision.Apr 13 2022, 2:34 PM
This revision is now accepted and ready to land.Apr 13 2022, 2:37 PM

Manual page changes appear consistent with addition to sysdecode.h. (Naive question: does always including stdio.h cause any noticeable bloat?)

(Naive question: does always including stdio.h cause any noticeable bloat?)

I'm not sure what you mean by bloat. The only negative effect of this is that a consumers which already includes stdio.h will force the C preprocessor to read the file again. This has no impact on the compiled code but forces the C preprocessor to read the file again.