Page MenuHomeFreeBSD
Differential D34680

getdirentries: return ENOENT for unlinked but still open directory.
ClosedPublic
Actions

Authored by dchagin on Mar 26 2022, 5:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jan 20, 3:30 PM
Unknown Object (File)
Sat, Jan 18, 12:34 AM
Unknown Object (File)
Tue, Jan 14, 2:21 PM
Unknown Object (File)
Mon, Jan 6, 8:05 PM
Unknown Object (File)
Dec 6 2024, 3:59 PM
Unknown Object (File)
Nov 21 2024, 6:46 AM
Unknown Object (File)
Nov 17 2024, 7:09 AM
Unknown Object (File)
Nov 11 2024, 2:04 PM
View All 56 Files
Subscribers
imp
mjg
pauamma_gundo.com

Details

Reviewers
pauamma_gundo.com
mjg
Group Reviewers
manpages
Commits
rG85575b7e0c7d: getdirentries: return ENOENT for unlinked but still open directory.
rGc6487446d7e9: getdirentries: return ENOENT for unlinked but still open directory.
Summary

To be more compliant to IEEE Std 1003.1-2008 (“POSIX.1”)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44899
Build 41787: arc lint + arc unit

Event Timeline

dchagin created this revision.Mar 26 2022, 5:23 PM
Herald added a reviewer: manpages. · View Herald TranscriptMar 26 2022, 5:23 PM
Herald added a subscriber: imp. · View Herald Transcript
dchagin requested review of this revision.Mar 26 2022, 5:23 PM
Harbormaster completed remote builds in B44896: Diff 104234.Mar 26 2022, 5:23 PM
mjg added a subscriber: mjg.Mar 26 2022, 7:33 PM
mjg added inline comments.
sys/kern/vfs_syscalls.c
3959

rmdir might have failed, but also this is not the place to do it. it should be in vop_rmdir_post

mjg added inline comments.Mar 26 2022, 8:07 PM
sys/kern/vfs_syscalls.c
3959

the flag itself is only used by gjournal, so a new one would have to be introduced for this purpose (VV_UNLINKED?)

pauamma_gundo.com requested changes to this revision.Mar 26 2022, 11:03 PM
pauamma_gundo.com added a subscriber: pauamma_gundo.com.

Other than that, English LGTM. Can't vouch for content.

lib/libc/sys/getdirentries.2
197

I'd be more specific here, maybe by repeating "unlinked but still open directory".

Also, while touching this area, I'd mention that getdents() has the same errno values (if it does).

This revision now requires changes to proceed.Mar 26 2022, 11:03 PM
dchagin updated this revision to Diff 104250.Mar 27 2022, 9:29 AM

Thanks!

Harbormaster completed remote builds in B44899: Diff 104250.Mar 27 2022, 9:29 AM
mjg added inline comments.Mar 27 2022, 11:40 AM
sys/kern/vfs_subr.c
5980

again you need to error check -- move it into the !rc case

mjg added inline comments.Mar 27 2022, 2:41 PM
sys/kern/vfs_syscalls.c
4197

i guess __predict_false on this would not hurt

dchagin updated this revision to Diff 104252.Mar 27 2022, 2:51 PM

ah, fixed, thank you, Mateusz

Harbormaster completed remote builds in B44900: Diff 104252.Mar 27 2022, 2:51 PM
mjg accepted this revision.Mar 27 2022, 3:01 PM
pauamma_gundo.com accepted this revision.Mar 27 2022, 9:14 PM
This revision is now accepted and ready to land.Mar 27 2022, 9:14 PM
Closed by commit rGc6487446d7e9: getdirentries: return ENOENT for unlinked but still open directory. (authored by dchagin). · Explain WhyApr 11 2022, 8:31 PM
This revision was automatically updated to reflect the committed changes.
dchagin added a commit: rGc6487446d7e9: getdirentries: return ENOENT for unlinked but still open directory..
dchagin added a commit: rG85575b7e0c7d: getdirentries: return ENOENT for unlinked but still open directory..Jun 17 2022, 7:42 PM

Revision Contents
Changeset List

PathSize
lib/
libc/
sys/
2 lines
sys/
kern/
1 line
4 lines
sys/
2 lines

Diff 104250

View Options

lib/libc/sys/getdirentries.2

Loading...
View Options

sys/kern/vfs_subr.c

Loading...
View Options

sys/kern/vfs_syscalls.c

Loading...
View Options

sys/sys/vnode.h

Loading...