Page MenuHomeFreeBSD

bsdinstall time: Revert dialogs titles
ClosedPublic

Authored by asiciliano on Mar 23 2022, 7:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 6, 4:31 AM
Unknown Object (File)
Fri, May 30, 12:15 AM
Unknown Object (File)
Fri, May 23, 7:05 AM
Unknown Object (File)
May 1 2025, 11:53 AM
Unknown Object (File)
May 1 2025, 3:47 AM
Unknown Object (File)
Apr 30 2025, 4:41 PM
Unknown Object (File)
Apr 18 2025, 3:55 PM
Unknown Object (File)
Apr 14 2025, 11:05 AM
Subscribers

Details

Summary

@jrtc27 , this review should fix:

Revert dialogs titles like before https://cgit.freebsd.org/src/commit/usr.sbin/bsdinstall/scripts/time?id=0e5c72c3cc5471dfa8cb42b018d623b1ef15dbe8: precisely delete spaces around titles to uniform to other installer components.

Test Plan

bsddialog --title 'Time & Date' --datebox '' 0 0

┌─────┤Time & Date├─────┐
│┌────┐ ┌─────────┐ ┌──┐│  
││2022│/│    March│/│23││  
│└────┘ └─────────┘ └──┘│  
├───────────────────────┤  
│  [  OK  ]   [Cancel]  │  
└───────────────────────┘

bsddialog --title 'Time & Date' --timebox '' 0 0

┌───┤Time & Date├───┐
│  ┌──┐ ┌──┐ ┌──┐   │  
│  │20│:│23│:│28│   │  
│  └──┘ └──┘ └──┘   │  
├───────────────────┤  
│[  OK  ]   [Cancel]│  
└───────────────────┘

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

asiciliano edited the test plan for this revision. (Show Details)
asiciliano added reviewers: bapt, emaste, jrtc27.
asiciliano added a subscriber: jrtc27.
This revision is now accepted and ready to land.Mar 23 2022, 8:40 PM
This revision was automatically updated to reflect the committed changes.