Page MenuHomeFreeBSD
Differential D34615

sysctl(8): Mention CTLFLAG_SKIP
ClosedPublic
Actions

Authored by cperciva on Mar 20 2022, 5:45 PM.
Tags
None
Referenced Files
F174290807: D34615.id104042.diff
Fri, Oct 2, 2:27 AM
F174232198: D34615.diff
Thu, Oct 1, 1:59 PM
Unknown Object (File)
Fri, Sep 25, 7:23 PM
Unknown Object (File)
Fri, Sep 25, 6:17 PM
Unknown Object (File)
Fri, Sep 25, 5:26 PM
Unknown Object (File)
Fri, Sep 25, 5:01 PM
Unknown Object (File)
Mon, Sep 21, 4:31 PM
Unknown Object (File)
Sun, Sep 13, 10:25 PM
View All Files
Subscribers
debdrup
imp

Details

Reviewers
debdrup
Group Reviewers
manpages
Commits
rG7d160dc9a1a2: sysctl(8): Mention CTLFLAG_SKIP
rG1dee7c74d1ab: sysctl(8): Mention CTLFLAG_SKIP
Summary

sysctl -a does not print values with this flag.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44834
Build 41722: arc lint + arc unit

Event Timeline

cperciva created this revision.Mar 20 2022, 5:45 PM
Herald added a reviewer: manpages. · View Herald TranscriptMar 20 2022, 5:45 PM
Herald added a subscriber: imp. · View Herald Transcript
cperciva requested review of this revision.Mar 20 2022, 5:45 PM
Harbormaster completed remote builds in B44832: Diff 104035.Mar 20 2022, 5:45 PM
cperciva added a child revision: D34616: tslog: Add CTLFLAG_SKIP to sysctls.Mar 20 2022, 5:45 PM
debdrup accepted this revision.Mar 20 2022, 6:06 PM
debdrup added a subscriber: debdrup.

I only spotted one minor nit, so I'll accept this and you can commit and push at your convenience after you've fixed it.

Remember to bump .Dd too, though - or bcr is gonna be disappointed. :P

sbin/sysctl/sysctl.8
67

CTLFLAG_SKIP is a defined variable, so mark it as such.

This revision is now accepted and ready to land.Mar 20 2022, 6:06 PM
cperciva updated this revision to Diff 104038.Mar 20 2022, 6:09 PM

Use .Dv

This revision now requires review to proceed.Mar 20 2022, 6:09 PM
Harbormaster completed remote builds in B44834: Diff 104038.Mar 20 2022, 6:09 PM
cperciva updated this revision to Diff 104039.Mar 20 2022, 6:11 PM

Add missing .Dd bump

Harbormaster completed remote builds in B44835: Diff 104039.Mar 20 2022, 6:11 PM
debdrup accepted this revision.Mar 20 2022, 6:25 PM

Good to go.

This revision is now accepted and ready to land.Mar 20 2022, 6:25 PM
Closed by commit rG1dee7c74d1ab: sysctl(8): Mention CTLFLAG_SKIP (authored by cperciva). · Explain WhyMar 20 2022, 6:32 PM
This revision was automatically updated to reflect the committed changes.
cperciva added a commit: rG1dee7c74d1ab: sysctl(8): Mention CTLFLAG_SKIP.
cperciva added a commit: rG7d160dc9a1a2: sysctl(8): Mention CTLFLAG_SKIP.Apr 4 2022, 7:12 PM

Revision Contents
Changeset List

PathSize
sbin/
sysctl/
5 lines

Diff 104038

View Options

sbin/sysctl/sysctl.8

Loading...