Differential D34588

namei: Treat non-tied KLDs as if they had INVARIANTS enabled
ClosedPublic
Actions

Authored by gallatin on Mar 17 2022, 2:45 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jul 3, 12:59 PM

	Unknown Object (File)
	Fri, Jul 3, 12:14 AM

	Unknown Object (File)
	Thu, Jul 2, 11:47 PM

	Unknown Object (File)
	Thu, Jul 2, 10:55 PM

	Unknown Object (File)
	Tue, Jun 30, 8:18 PM

	Unknown Object (File)
	Jun 18 2026, 10:46 PM

	Unknown Object (File)
	Jun 18 2026, 5:56 PM

	Unknown Object (File)
	Jun 18 2026, 2:40 PM

Subscribers

Details

Reviewers

mjg
kevans

Commits

rGb50abe6bd45d: namei: Treat non-tied KLDs as if they had INVARIANTS enabled

Summary

When working with a vendor to debug their kernel module, I found that a non-tied kld will panic due to "namei: bad debugflags " on a kernel compiled with INVARIANTS because non-tied KLDs do not pick up the initialization that is done in NDINIT_DBG/NDREINIT_DBG().

Fix this by making this initialization happen for non- KLD_TIED as well as INVARIANTS

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

gallatin created this revision.Mar 17 2022, 2:45 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 17 2022, 2:45 PM

gallatin requested review of this revision.Mar 17 2022, 2:45 PM

this needs a comment what the hack is for, as in how come this is not picked up automatically

Added a comment to why we enable debug stuff here as per mjg's request

mjg accepted this revision.Mar 17 2022, 5:34 PM

This revision is now accepted and ready to land.Mar 17 2022, 5:34 PM

Closed by commit rGb50abe6bd45d: namei: Treat non-tied KLDs as if they had INVARIANTS enabled (authored by gallatin). · Explain WhyMar 18 2022, 2:17 PM

This revision was automatically updated to reflect the committed changes.

gallatin added a commit: rGb50abe6bd45d: namei: Treat non-tied KLDs as if they had INVARIANTS enabled.

Revision Contents
Changeset List

Path

Size

sys/

sys/

5 lines

Diff 103952

sys/sys/namei.h

Loading...