ocs_fc: Ignore flogi failure when the discovery is already done.
ClosedPublic
Actions

Authored by ram on Mar 3 2022, 12:06 PM.

Details

Reviewers

ken
mav

Commits

rG927f2126d289: ocs_fc: Ignore flogi failure when the discovery is already done.
rG456c941b7d7e: ocs_fc: Ignore flogi failure when the discovery is already done.
rG79c56c9af583: ocs_fc: Ignore flogi failure when the discovery is already done.

Summary

Some targets are not responding to the FLOGI in point-to-point topology,
If the pt2pt discovery is done, Ignore the FLOGI failure.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44626
Build 41514: arc lint + arc unit

Event Timeline

ram created this revision.Mar 3 2022, 12:06 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 3 2022, 12:06 PM

ram requested review of this revision.Mar 3 2022, 12:06 PM

Harbormaster completed remote builds in B44626: Diff 103430.Mar 3 2022, 12:06 PM

I don't think I can properly review this change without diving in deeply. It just looks weird to me first print "shutting down sport" but then "p2p winner, domain already attached\n" and post OCS_EVT_DOMAIN_ATTACH_OK.

In D34422#779953, @mav wrote:

I don't think I can properly review this change without diving in deeply. It just looks weird to me first print "shutting down sport" but then "p2p winner, domain already attached\n" and post OCS_EVT_DOMAIN_ATTACH_OK.

I will change the log sequence while check-in.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2022, 4:57 AM

Closed by commit rG79c56c9af583: ocs_fc: Ignore flogi failure when the discovery is already done. (authored by Ram Kishore Vegesna <ram@FreeBSD.org>). · Explain Why

This revision was automatically updated to reflect the committed changes.

Ram Kishore Vegesna <ram@FreeBSD.org> added a commit: rG79c56c9af583: ocs_fc: Ignore flogi failure when the discovery is already done..

Ram Kishore Vegesna <ram@FreeBSD.org> added a commit: rG456c941b7d7e: ocs_fc: Ignore flogi failure when the discovery is already done..Mar 7 2022, 11:01 AM

Ram Kishore Vegesna <ram@FreeBSD.org> added a commit: rG927f2126d289: ocs_fc: Ignore flogi failure when the discovery is already done..Mar 7 2022, 11:03 AM