Page MenuHomeFreeBSD
Differential D34422

ocs_fc: Ignore flogi failure when the discovery is already done.
ClosedPublic
Actions

Authored by ram on Mar 3 2022, 12:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 16, 5:14 AM
Unknown Object (File)
Tue, Oct 14, 1:15 AM
Unknown Object (File)
Mon, Oct 13, 2:12 AM
Unknown Object (File)
Mon, Oct 13, 2:12 AM
Unknown Object (File)
Mon, Oct 13, 2:12 AM
Unknown Object (File)
Sun, Oct 12, 2:23 PM
Unknown Object (File)
Sep 20 2025, 9:12 AM
Unknown Object (File)
Sep 16 2025, 6:34 PM
View All 91 Files
Subscribers
imp

Details

Reviewers
ken
mav
Commits
rG927f2126d289: ocs_fc: Ignore flogi failure when the discovery is already done.
rG456c941b7d7e: ocs_fc: Ignore flogi failure when the discovery is already done.
rG79c56c9af583: ocs_fc: Ignore flogi failure when the discovery is already done.
Summary

Some targets are not responding to the FLOGI in point-to-point topology,
If the pt2pt discovery is done, Ignore the FLOGI failure.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ram created this revision.Mar 3 2022, 12:06 PM
Herald added a subscriber: imp. · View Herald TranscriptMar 3 2022, 12:06 PM
ram requested review of this revision.Mar 3 2022, 12:06 PM
Harbormaster completed remote builds in B44626: Diff 103430.Mar 3 2022, 12:06 PM
mav added a comment.Mar 3 2022, 3:15 PM

I don't think I can properly review this change without diving in deeply. It just looks weird to me first print "shutting down sport" but then "p2p winner, domain already attached\n" and post OCS_EVT_DOMAIN_ATTACH_OK.

ram added a comment.Mar 3 2022, 3:38 PM
In D34422#779953, @mav wrote:

I don't think I can properly review this change without diving in deeply. It just looks weird to me first print "shutting down sport" but then "p2p winner, domain already attached\n" and post OCS_EVT_DOMAIN_ATTACH_OK.

I will change the log sequence while check-in.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 4 2022, 4:57 AM
Closed by commit rG79c56c9af583: ocs_fc: Ignore flogi failure when the discovery is already done. (authored by Ram Kishore Vegesna <ram@FreeBSD.org>). · Explain Why
This revision was automatically updated to reflect the committed changes.
Ram Kishore Vegesna <ram@FreeBSD.org> added a commit: rG79c56c9af583: ocs_fc: Ignore flogi failure when the discovery is already done..
Ram Kishore Vegesna <ram@FreeBSD.org> added a commit: rG456c941b7d7e: ocs_fc: Ignore flogi failure when the discovery is already done..Mar 7 2022, 11:01 AM
Ram Kishore Vegesna <ram@FreeBSD.org> added a commit: rG927f2126d289: ocs_fc: Ignore flogi failure when the discovery is already done..Mar 7 2022, 11:03 AM

Revision Contents
Changeset List

PathSize
sys/
dev/
ocs_fc/
16 lines

Diff 103479

View Options

sys/dev/ocs_fc/ocs_fabric.c

Loading...