Differential D34328

diff: Use change start when searching for function names
ClosedPublic
Actions

Authored by thj on Feb 21 2022, 11:19 AM.

Details

Reviewers

bapt

Group Reviewers

Klara

Commits

rG4be7d087c2b5: diff: Use start of change when searching for function

Summary

Use the start of change when searching for a function rather than the
start of the context. In short functions if this could result in search
for the function name starting from before the function definition.

This was exposed by
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=262086

Test Plan

This fixes the previously failing diff functioname test, all other tests pass.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

thj created this revision.Feb 21 2022, 11:19 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 21 2022, 11:19 AM

thj requested review of this revision.Feb 21 2022, 11:19 AM

Harbormaster completed remote builds in B44523: Diff 103024.Feb 21 2022, 11:19 AM

minor format question. Change looks correct.

usr.bin/diff/diffreg.c
1566	why add the extra blank line?

bapt accepted this revision.Feb 22 2022, 1:06 PM

This revision is now accepted and ready to land.Feb 22 2022, 1:06 PM

mhorne added a subscriber: mhorne.Feb 22 2022, 8:11 PM

mhorne added inline comments.

usr.bin/diff/diffreg.c
1465

Closed by commit rG4be7d087c2b5: diff: Use start of change when searching for function (authored by thj). · Explain WhyMar 1 2022, 1:28 PM

This revision was automatically updated to reflect the committed changes.

thj added a commit: rG4be7d087c2b5: diff: Use start of change when searching for function.

Revision Contents
Changeset List

Path

Size

usr.bin/

diff/

diffreg.c

4 lines

Diff 103323

View Options

diff: Use change start when searching for function namesClosedPublicActions