Page MenuHomeFreeBSD

vfs_unregister: fix error handling
ClosedPublic

Authored by vangyzen on Feb 25 2022, 3:41 PM.
Tags
None
Referenced Files
F148462519: D34375.id103227.diff
Wed, Mar 18, 1:35 AM
Unknown Object (File)
Sun, Mar 15, 1:47 PM
Unknown Object (File)
Tue, Feb 17, 3:58 PM
Unknown Object (File)
Feb 8 2026, 10:24 AM
Unknown Object (File)
Feb 7 2026, 5:01 PM
Unknown Object (File)
Jan 30 2026, 6:44 PM
Unknown Object (File)
Jan 27 2026, 4:31 PM
Unknown Object (File)
Dec 1 2025, 6:41 AM
Subscribers

Details

Summary

Due to misplaced braces, an error from vfs_uninit() in the VFCF_SBDRY
case was ignored.

Reported by: Anton Rang <rang@acm.org>
MFC after: 1 week
Sponsored by: Dell EMC Isilon

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44575
Build 41463: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Feb 25 2022, 3:44 PM

Because of this bug, the nfs VFS module was incorrectly unloaded. However, the nfscl module still refused to unload, so the result was mostly harmless, meaning the kernel didn't panic. The worst effect was, NFS was no longer listed as a VFS, so no NFS mounts could be created until the next reboot. Amusingly, kldload failed with EOPNOTSUPP before and after the fix, so I had to use dtrace to see the difference.

This revision was automatically updated to reflect the committed changes.