Differential D34350

LinuxKPI: change DECLARE_FLEX_ARRAY()
ClosedPublic
Actions

Authored by bz on Feb 22 2022, 10:51 PM.

Details

Reviewers

• hselasky

Group Reviewers

linuxkpi

Commits

rG4605fd58a353: LinuxKPI: change DECLARE_FLEX_ARRAY()
rGfab601c5b76a: LinuxKPI: change DECLARE_FLEX_ARRAY()

Summary

DECLARE_FLEX_ARRAY can be used inside a structure. On FreeBSD due to
-Wgnu-variable-sized-type-not-at-end this yields an error. Use [0]
instead of [] to overcome this.

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44542
Build 41430: arc lint + arc unit

Event Timeline

bz created this revision.Feb 22 2022, 10:51 PM

Herald added subscribers: emaste, imp. · View Herald TranscriptFeb 22 2022, 10:51 PM

bz requested review of this revision.Feb 22 2022, 10:51 PM

Harbormaster completed remote builds in B44542: Diff 103135.Feb 22 2022, 10:51 PM

I think there are some issues with [0] aswell, but I don't remember exactly right now.

This revision is now accepted and ready to land.Feb 24 2022, 9:19 AM

Closed by commit rGfab601c5b76a: LinuxKPI: change DECLARE_FLEX_ARRAY() (authored by bz). · Explain WhyFeb 24 2022, 7:59 PM

This revision was automatically updated to reflect the committed changes.

bz added a commit: rGfab601c5b76a: LinuxKPI: change DECLARE_FLEX_ARRAY().

bz added a commit: rG4605fd58a353: LinuxKPI: change DECLARE_FLEX_ARRAY().Feb 27 2022, 11:43 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

kernel.h

2 lines

Diff 103135

View Options

sys/compat/linuxkpi/common/include/linux/kernel.h

LinuxKPI: change DECLARE_FLEX_ARRAY()ClosedPublicActions