camcontrol: Force a rescan of the lun after firmware download.
ClosedPublic
Actions

Authored by imp on Feb 20 2022, 9:45 PM.

Details

Reviewers

ken
scottl
mav
trasz

Commits

rG327da43602cc: camcontrol: Force a rescan of the lun after firmware download.
rG9835900cb95b: camcontrol: Force a rescan of the lun after firmware download.

Summary

After downloading the firmware to a device, it's inquiry data likely
will change. Force a rescan of the lun with the CAM_EXPECT_INQ_CHANGE
flag to get it to record the new inqury data as being expected. This
avoids a 'camcontrol rescan' on the device which will (uselessly?)
detach/attach the disk (da, ada) device. This brings fwdownload up to
nvmecontrol's ability to do the same thing w/o changing the exposed
nvme/nvd/nda device.

I've also successfully updated root drive firmware w/o crashing the
system for the first time.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44520
Build 41408: arc lint + arc unit

Event Timeline

imp requested review of this revision.Feb 20 2022, 9:45 PM

imp created this revision.

Harbormaster completed remote builds in B44516: Diff 103011.Feb 20 2022, 9:45 PM

imp added reviewers: ken, scottl, mav, trasz.Feb 20 2022, 9:47 PM

mav added inline comments.Feb 20 2022, 10:44 PM

sbin/camcontrol/fwdownload.c
777	Does firmware update works in context of LUN or target? What should we expect from dual-LUN disks here?
781	I don't think rescan needs timeout.
791	Combining two error scenarios you may reporting between confusing and wrong.

imp added inline comments.Feb 21 2022, 12:44 AM

sbin/camcontrol/fwdownload.c
777	The dual actuators we have, from two different vendors, only support firmware upgrade on LUN 0. However, one of them said, in an off hand way, that the standard allows any lun to work. Having said that, perhaps I should do a SCAN_BUS here with lun any, eh? That might make the ata drives work... right now, they won't rescan until I do a camcontrol rescan by hand afterwards (but the CAM_EXPECT_INQ_CHANGE flag causes the PROBE_NO_ANNOUNCE flag to get set, and it appears that it is never cleared.
781	OK. I just copied this code from the rescan camcontrol code... But camcontrol could use a lot of cleanup
791	copied directly fromfw_download_img, but I'm happy to separate them out here (and there)/ But I'd like to do the latter as a followup cleanup series.

mav added inline comments.Feb 21 2022, 2:07 AM

sbin/camcontrol/fwdownload.c
777	I was thinking about XPT_SCAN_TGT. Bus is definitely too wide.

Update per mav's suggestion to use XPT_SCAN_TGT

However, of ata devices (and maybe scsi too), don't have the b:t:l filled into
the cam_device structure. So do a XPT_GDEVLIST to get them in all cases and use
those for the rescan.

Also, I'd forgotten XPT_SCAN_* can only be sent via /dev/xpt, and the prior
version had a premature optimization to use cam_send_ccb rather than to do a
pass through command via xpt. Restore that so the scan actually happens.

Harbormaster completed remote builds in B44519: Diff 103016.Feb 21 2022, 4:52 AM

remove stray n

Also, the prior update, since I have to do this one, also improved the error
reporting to be less confusing...

Harbormaster completed remote builds in B44520: Diff 103017.Feb 21 2022, 4:57 AM

imp edited the summary of this revision. (Show Details)Feb 21 2022, 5:01 AM

imp edited the test plan for this revision. (Show Details)Feb 21 2022, 5:03 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 22 2022, 5:44 PM

Closed by commit rG9835900cb95b: camcontrol: Force a rescan of the lun after firmware download. (authored by imp). · Explain Why

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG9835900cb95b: camcontrol: Force a rescan of the lun after firmware download..

imp added a commit: rG327da43602cc: camcontrol: Force a rescan of the lun after firmware download..Mar 9 2022, 8:53 PM