ctl ramdisk: Free compare buffer after a compare I/O request.
ClosedPublic
Actions

Authored by jhb on Feb 18 2022, 5:30 PM.

Details

Reviewers

mav
trasz
ken

Group Reviewers

cam

Commits

rGd538e52c515b: ctl ramdisk: Free compare buffer after a compare I/O request.
rGbd6e8729d6f6: ctl ramdisk: Free compare buffer after a compare I/O request.

Summary

For a compare request, the ramdisk backend allocates a temporary
buffer to hold the I/O data and then compares it against the LUN's
pages in ctl_backend_ramdisk_cmp after the data has been filled.
However, the tempory buffer was leaked when after the comparison was
complete. Fix this by freeing the buffer after the comparison.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44501
Build 41389: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 18 2022, 5:30 PM

Herald added a reviewer: cam. · View Herald TranscriptFeb 18 2022, 5:30 PM

Herald added a subscriber: imp. · View Herald Transcript

jhb requested review of this revision.Feb 18 2022, 5:30 PM

Harbormaster completed remote builds in B44501: Diff 102951.Feb 18 2022, 5:30 PM

I haven't figured out a good way to test this (don't see a way to easily generate COMPARE WRITE or VERIFY commands to daX), just noticed this while investigating a possible memory leak reported by Chelsio's QA folks.

Looks good to me.

There are sg_compare_and_write and sg_verify in sg3_utils port.

This revision is now accepted and ready to land.Feb 18 2022, 5:47 PM

Thanks, I tested with sg_verify and sg_compare_and_write.

Closed by commit rGbd6e8729d6f6: ctl ramdisk: Free compare buffer after a compare I/O request. (authored by jhb). · Explain WhyFeb 18 2022, 11:21 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rGbd6e8729d6f6: ctl ramdisk: Free compare buffer after a compare I/O request..

jhb added a commit: rGd538e52c515b: ctl ramdisk: Free compare buffer after a compare I/O request..Apr 29 2022, 11:14 PM