Page MenuHomeFreeBSD
Differential D34202

Search for objective c method definitions
ClosedPublic
Actions

Authored by thj on Feb 8 2022, 1:51 PM.
Tags
None
Referenced Files
F174560905: D34202.id102494.diff
Sun, Oct 4, 4:23 AM
Unknown Object (File)
Wed, Sep 30, 11:10 AM
Unknown Object (File)
Mon, Sep 28, 3:38 PM
Unknown Object (File)
Mon, Sep 28, 1:52 PM
Unknown Object (File)
Mon, Sep 28, 1:31 PM
Unknown Object (File)
Sat, Sep 26, 11:33 PM
Unknown Object (File)
Fri, Sep 18, 10:57 PM
Unknown Object (File)
Sat, Sep 12, 3:45 AM
View All Files
Subscribers
imp
jilles
pauamma_chezdork.com

Details

Reviewers
bapt
Group Reviewers
Klara
manpages
Commits
rG8f79bd9b8571: diff: Detect Objective-C methods
Summary

When searching back for function definitions, consider lines starting
with '+' and '-', this allows us to pick up objective methods as well as
c style function definitions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44334
Build 41222: arc lint + arc unit

Event Timeline

thj created this revision.Feb 8 2022, 1:51 PM
Herald added a subscriber: imp. · View Herald TranscriptFeb 8 2022, 1:51 PM
thj requested review of this revision.Feb 8 2022, 1:51 PM
Harbormaster completed remote builds in B44334: Diff 102494.Feb 8 2022, 1:51 PM
bapt accepted this revision.Feb 8 2022, 2:36 PM

don't forget to add a unit test

This revision is now accepted and ready to land.Feb 8 2022, 2:36 PM
thj updated this revision to Diff 102609.Feb 10 2022, 3:17 PM
  • Add tests for finding function names
This revision now requires review to proceed.Feb 10 2022, 3:17 PM
Herald added a reviewer: manpages. · View Herald TranscriptFeb 10 2022, 3:17 PM
Harbormaster completed remote builds in B44390: Diff 102609.Feb 10 2022, 3:18 PM
pauamma_chezdork.com added a subscriber: pauamma_chezdork.com.Feb 11 2022, 3:29 AM

Other than that wording tweak, spelling and grammar in manual page change LGTM.

usr.bin/diff/diff.1
400 ↗(On Diff #102609)
bapt accepted this revision.Feb 11 2022, 7:16 PM
This revision is now accepted and ready to land.Feb 11 2022, 7:16 PM
jilles added a subscriber: jilles.Feb 11 2022, 9:49 PM
jilles added inline comments.
usr.bin/diff/tests/functionname_objcm.in
21 ↗(On Diff #102609)

Fortunately, this code is never run :) The pointer subtraction is immediate undefined behaviour.

Closed by commit rG8f79bd9b8571: diff: Detect Objective-C methods (authored by thj). · Explain WhyFeb 18 2022, 3:13 PM
This revision was automatically updated to reflect the committed changes.
thj added a commit: rG8f79bd9b8571: diff: Detect Objective-C methods.

Revision Contents
Changeset List

PathSize
usr.bin/
diff/
3 lines

Diff 102494

View Options

usr.bin/diff/diffreg.c

Loading...