Paths

Table of Contentst

Differential D34197

linuxkpi xarray: Correct expression in assertion.
ClosedPublic
Actions

Authored by jhb on Feb 7 2022, 9:35 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 17, 11:32 AM

	Unknown Object (File)
	Mon, Nov 17, 7:01 AM

	Unknown Object (File)
	Mon, Nov 17, 6:59 AM

	Unknown Object (File)
	Mon, Nov 17, 5:56 AM

	Unknown Object (File)
	Mon, Nov 17, 5:47 AM

	Unknown Object (File)
	Mon, Nov 17, 3:43 AM

	Unknown Object (File)
	Mon, Nov 17, 3:42 AM

	Unknown Object (File)
	Mon, Nov 17, 3:36 AM

View All 60 Files

Subscribers

Details

Reviewers

• hselasky
wulf

Commits

rGf70fe58d0a8d: linuxkpi xarray: Correct expression in assertion.
rGb0c1600a8c42: linuxkpi xarray: Correct expression in assertion.

Summary

Reported by: GCC -Wparantheses

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 44328
Build 41216: arc lint + arc unit

Event Timeline

jhb created this revision.Feb 7 2022, 9:35 PM

Herald added subscribers: linuxkpi, imp. · View Herald TranscriptFeb 7 2022, 9:35 PM

jhb requested review of this revision.Feb 7 2022, 9:35 PM

Harbormaster completed remote builds in B44328: Diff 102476.Feb 7 2022, 9:35 PM

jhb mentioned this in D34145: linuxkpi: Add parentheses to pacify -Wparentheses warnings from GCC..Feb 7 2022, 9:35 PM

LGTM based on the discussion in D34145

jhb added inline comments.Feb 7 2022, 9:37 PM

sys/compat/linuxkpi/common/src/linux_xarray.c
106	I kept the '!= 0' only because that is the preferred FreeBSD style. Note that one could rewrite this assertion as: if ((xa->flags & XA_FLAGS_ALLOC1) != 0) MPASS(mask > 1); Not sure if that would be more readable?

emaste added inline comments.Feb 7 2022, 9:38 PM

sys/compat/linuxkpi/common/src/linux_xarray.c
106	We also want to assert `mask > 0` for `xa->flags & XA_FLAGS_ALLOC1 == 0` though do we not?

LGTM

This revision is now accepted and ready to land.Feb 7 2022, 10:37 PM

• hselasky accepted this revision.Feb 7 2022, 11:26 PM

jhb marked an inline comment as done.Feb 11 2022, 9:46 PM

jhb added inline comments.

sys/compat/linuxkpi/common/src/linux_xarray.c
106	Hmmm, I had misread as it as being tautological (>= 0).

Closed by commit rGb0c1600a8c42: linuxkpi xarray: Correct expression in assertion. (authored by jhb). · Explain WhyFeb 11 2022, 10:00 PM

This revision was automatically updated to reflect the committed changes.

jhb marked an inline comment as done.

jhb added a commit: rGb0c1600a8c42: linuxkpi xarray: Correct expression in assertion..

jhb added a commit: rGf70fe58d0a8d: linuxkpi xarray: Correct expression in assertion..May 11 2022, 12:30 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

src/

4 lines

Diff 102476

sys/compat/linuxkpi/common/src/linux_xarray.c

Loading...