Differential D34146

iwlwifi: Disable -Wformat when building with GCC.
ClosedPublic
Actions

Authored by jhb on Feb 2 2022, 8:21 PM.

Tags

None

Referenced Files

	F140003150: D34146.diff
	Thu, Dec 18, 9:36 PM

	Unknown Object (File)
	Fri, Dec 12, 10:34 AM

	Unknown Object (File)
	Fri, Dec 12, 9:05 AM

	Unknown Object (File)
	Thu, Dec 11, 3:11 AM

	Unknown Object (File)
	Sat, Dec 6, 1:18 PM

	Unknown Object (File)
	Wed, Dec 3, 5:15 AM

	Unknown Object (File)
	Wed, Dec 3, 2:37 AM

	Unknown Object (File)
	Sun, Nov 30, 10:07 PM

View All 88 Files

Subscribers

Details

Reviewers

Commits

rGb9cab0f39cc8: iwlwifi: Disable -Wformat when building with GCC.
rG87c5d39f77bc: iwlwifi: Disable -Wformat when building with GCC.

Summary

GCC's -Wformat complains about NULL format strings passed to
iwl_fw_dbg_collect_trig (though the function handles NULL format
strings). Curious that upstream iwlwifi in Linux is built with GCC
and explicitly opts into this warning via the __printf() attribute.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Feb 2 2022, 8:21 PM

Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2022, 8:21 PM

jhb requested review of this revision.Feb 2 2022, 8:21 PM

Harbormaster completed remote builds in B44253: Diff 102274.Feb 2 2022, 8:21 PM

Yeah, on the other hand they seem to have trouble adding extra options to just the driver -- from my reading between lines; who knows...

This revision is now accepted and ready to land.Feb 2 2022, 9:44 PM

Closed by commit rG87c5d39f77bc: iwlwifi: Disable -Wformat when building with GCC. (authored by jhb). · Explain WhyFeb 3 2022, 6:49 PM

This revision was automatically updated to reflect the committed changes.

jhb added a commit: rG87c5d39f77bc: iwlwifi: Disable -Wformat when building with GCC..

jhb added a commit: rGb9cab0f39cc8: iwlwifi: Disable -Wformat when building with GCC..Jan 24 2023, 4:47 AM

Revision Contents
Changeset List

Path

Size

sys/

modules/

iwlwifi/

3 lines

Diff 102336

sys/modules/iwlwifi/Makefile

Loading...