Page MenuHomeFreeBSD

iwlwifi: Disable -Wformat when building with GCC.
ClosedPublic

Authored by jhb on Feb 2 2022, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 5, 4:37 AM
Unknown Object (File)
Sat, Oct 5, 1:56 AM
Unknown Object (File)
Sat, Oct 5, 12:20 AM
Unknown Object (File)
Fri, Oct 4, 2:10 PM
Unknown Object (File)
Tue, Oct 1, 9:45 PM
Unknown Object (File)
Tue, Oct 1, 9:29 PM
Unknown Object (File)
Mon, Sep 30, 11:47 PM
Unknown Object (File)
Mon, Sep 30, 5:17 PM
Subscribers

Details

Summary

GCC's -Wformat complains about NULL format strings passed to
iwl_fw_dbg_collect_trig (though the function handles NULL format
strings). Curious that upstream iwlwifi in Linux is built with GCC
and explicitly opts into this warning via the __printf() attribute.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44253
Build 41141: arc lint + arc unit

Event Timeline

jhb requested review of this revision.Feb 2 2022, 8:21 PM

Yeah, on the other hand they seem to have trouble adding extra options to just the driver -- from my reading between lines; who knows...

This revision is now accepted and ready to land.Feb 2 2022, 9:44 PM