Page MenuHomeFreeBSD

iwlwifi: Disable -Wformat when building with GCC.
ClosedPublic

Authored by jhb on Feb 2 2022, 8:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Aug 6, 12:37 AM
Unknown Object (File)
Tue, Jul 29, 4:16 AM
Unknown Object (File)
Jun 29 2025, 3:40 PM
Unknown Object (File)
Jun 28 2025, 7:56 AM
Unknown Object (File)
Jun 22 2025, 1:05 PM
Unknown Object (File)
Jun 22 2025, 10:23 AM
Unknown Object (File)
Jun 21 2025, 4:33 AM
Unknown Object (File)
Jun 18 2025, 9:19 PM
Subscribers

Details

Summary

GCC's -Wformat complains about NULL format strings passed to
iwl_fw_dbg_collect_trig (though the function handles NULL format
strings). Curious that upstream iwlwifi in Linux is built with GCC
and explicitly opts into this warning via the __printf() attribute.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jhb requested review of this revision.Feb 2 2022, 8:21 PM

Yeah, on the other hand they seem to have trouble adding extra options to just the driver -- from my reading between lines; who knows...

This revision is now accepted and ready to land.Feb 2 2022, 9:44 PM