Page MenuHomeFreeBSD
Differential D34155

fix build arm64 with options IOMMU
ClosedPublic
Actions

Authored by jsm on Feb 3 2022, 11:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 25, 5:34 AM
Unknown Object (File)
Mon, Dec 9, 3:25 AM
Unknown Object (File)
Sat, Nov 30, 8:51 AM
Unknown Object (File)
Nov 27 2024, 2:39 AM
Unknown Object (File)
Nov 21 2024, 2:10 PM
Unknown Object (File)
Nov 1 2024, 4:32 PM
Unknown Object (File)
Oct 25 2024, 4:19 PM
Unknown Object (File)
Oct 21 2024, 7:47 AM
View All 75 Files
Subscribers
andrew
emaste
imp

Details

Reviewers
kib
manu
Commits
rGea07ba11700f: sys/arm64/iommu/iommu_pmap.c readd sys/systm.h
Summary

after d950c5898a2d UINT64_C and bzero is no longer defined in sys/arm64/iommu/iommu_pmap.c readd sys/systm.h

Test Plan

Builds with stock generic config with "options IOMMU" added

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jsm created this revision.Feb 3 2022, 11:15 AM
Herald added a reviewer: manu. · View Herald TranscriptFeb 3 2022, 11:15 AM
Herald added subscribers: emaste, andrew, imp. · View Herald Transcript
jsm requested review of this revision.Feb 3 2022, 11:15 AM
jsm updated this revision to Diff 102314.Feb 3 2022, 11:58 AM
jsm edited the summary of this revision. (Show Details)
jsm edited the test plan for this revision. (Show Details)

bzero is needed as well, so include full systm.h

kib added inline comments.Feb 3 2022, 12:37 PM
sys/arm64/iommu/iommu_pmap.c
45

While there, sys/mutex.h and sys/rwlock.h require sys/lock.h. Put it before mutex.

50

sys/systm.h should go right after sys/param.h

kib added a comment.Feb 3 2022, 12:42 PM

There is probably no LINT config with this option, which is why I did not noticed the problem while doing tinderbox for sys/kassert.h. IMO it is worth adding it to arm64 LINT, or whatever the place is.

jsm updated this revision to Diff 102325.Feb 3 2022, 3:26 PM

reorder includes

jsm marked an inline comment as done.Feb 3 2022, 3:27 PM
jsm marked an inline comment as done.
kib accepted this revision.Feb 3 2022, 3:37 PM

Will you add the option to LINT?

This revision is now accepted and ready to land.Feb 3 2022, 3:37 PM
Closed by commit rGea07ba11700f: sys/arm64/iommu/iommu_pmap.c readd sys/systm.h (authored by jsm). · Explain WhyFeb 3 2022, 7:06 PM
This revision was automatically updated to reflect the committed changes.
jsm added a commit: rGea07ba11700f: sys/arm64/iommu/iommu_pmap.c readd sys/systm.h.

Revision Contents
Changeset List

PathSize
sys/
arm64/
iommu/
1 line

Diff 102314

View Options

sys/arm64/iommu/iommu_pmap.c

Loading...