Page MenuHomeFreeBSD
Differential D4169

Change default directory used by USES=autoreconf to WRKSRC
ClosedPublic
Actions

Authored by jbeich on Nov 15 2015, 7:45 PM.
Tags
None
Referenced Files
F103231636: D4169.id15145.diff
Fri, Nov 22, 11:24 AM
Unknown Object (File)
Thu, Nov 21, 6:15 PM
Unknown Object (File)
Wed, Nov 20, 11:26 AM
Unknown Object (File)
Wed, Nov 20, 7:18 AM
Unknown Object (File)
Wed, Nov 20, 5:57 AM
Unknown Object (File)
Wed, Nov 20, 5:57 AM
Unknown Object (File)
Tue, Nov 19, 1:09 PM
Unknown Object (File)
Tue, Nov 19, 8:19 AM
View All Files
Subscribers
None

Details

Reviewers
tijl
Group Reviewers
portmgr
Commits
rP413185: Change default directory used by USES=autoreconf to WRKSRC
Test Plan

USES=autoreconf ports that change CONFIGURE_WRKSRC:

  • graphics/p5-ming
  • graphics/py-ming

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 1156
Build 1160: arc lint + arc unit

Event Timeline

jbeich updated this revision to Diff 10209.Nov 15 2015, 7:45 PM
jbeich retitled this revision from to Change default directory used by USES=autoreconf to WRKSRC.
jbeich updated this object.
jbeich edited the test plan for this revision. (Show Details)
jbeich added reviewers: portmgr, tijl.
Herald edited edge metadata. · View Herald TranscriptNov 15 2015, 7:45 PM
jbeich mentioned this in D4157: Add CONFIGURE_OUTSOURCE support.Nov 15 2015, 7:49 PM
jbeich added a child revision: D4157: Add CONFIGURE_OUTSOURCE support.Nov 15 2015, 7:50 PM
jbeich edited the test plan for this revision. (Show Details)Nov 15 2015, 7:57 PM
jbeich edited edge metadata.
jbeich updated this revision to Diff 10215.Nov 15 2015, 8:40 PM
jbeich edited the test plan for this revision. (Show Details)
  • Fix graphics/p[5y]-ming by not poking USE_GITHUB variables instead of redefining AUTORECONF_WRKSRC
Herald edited edge metadata. · View Herald TranscriptNov 15 2015, 8:40 PM
jbeich updated this revision to Diff 10216.Nov 15 2015, 8:48 PM
jbeich edited edge metadata.

Oops, use PATCH_WRKSRC in post-patch to avoid confusion.

Herald edited edge metadata. · View Herald TranscriptNov 15 2015, 8:48 PM
jbeich added a reviewer: sunpoet.Nov 15 2015, 8:50 PM
tijl accepted this revision.Nov 16 2015, 9:49 AM
tijl edited edge metadata.

For me the patch is fine, but I would just use ${WRKSRC}/perl_ext (or py_ext) in post-patch. Since autoreconf runs in WRKSRC it's possible that in the future some files may need to be patched there and then a non-default PATCH_WRKSRC can be a bit confusing or unexpected.

jbeich updated this revision to Diff 10240.Nov 16 2015, 4:02 PM
jbeich edited edge metadata.
In D4169#87753, @tijl wrote:

I would just use ${WRKSRC}/perl_ext (or py_ext) in post-patch.

graphics/py-ming already relies on non-default PATCH_WRKSRC as it modifies WRKSRC. I've tried to keep p5-ming consistent with it. However, rebasing the patches would complicate this differential even more.

Let's go back to AUTORECONF_WRKSRC then. Improving p[5y]-ming ports is out of scope here.

Herald edited edge metadata. · View Herald TranscriptNov 16 2015, 4:02 PM
jbeich removed a reviewer: sunpoet.Nov 16 2015, 4:03 PM
jbeich updated this revision to Diff 14640.Mar 26 2016, 9:54 PM

Rebased.

Herald edited edge metadata. · View Herald TranscriptMar 26 2016, 9:54 PM
jbeich added a child revision: D5817: games/qqwing: convert to CONFIGURE_OUTSOURCE.Apr 3 2016, 12:13 AM
Closed by commit rP413185: Change default directory used by USES=autoreconf to WRKSRC (authored by jbeich). · Explain WhyApr 13 2016, 10:37 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
Mk/
Uses/
7 lines

Diff 10209

View Options

Mk/Uses/autoreconf.mk

Loading...