Page MenuHomeFreeBSD
Differential D32154

MMCCAM - Convert driver to use the mmc_sim interface
ClosedPublic
Actions

Authored by hlh_restart.be on Sep 27 2021, 9:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 21, 10:43 PM
Unknown Object (File)
Sun, Jun 16, 6:14 PM
Unknown Object (File)
Sun, Jun 16, 9:02 AM
Unknown Object (File)
Wed, Jun 12, 5:22 PM
Unknown Object (File)
Sun, Jun 9, 2:56 PM
Unknown Object (File)
Sun, Jun 9, 2:56 PM
Unknown Object (File)
Sun, Jun 9, 2:56 PM
Unknown Object (File)
May 23 2024, 10:21 PM
View All 48 Files
Subscribers
imp

Details

Reviewers
jkim
Commits
rG785a5b8d91ab: rtsx: Update driver version number to 2.1c
rG23566767c37e: rtsx: Do not display pci_read_config() errors during rtsx_init()
rGa1b4c74dadeb: rtsx: Add CTLFLAG_STATS flag for read and write counters
rG4efab785f6c4: rtsx: Prefer __FreeBSD_version over __FreeBSD__
rG545def055b4a: rtsx: Convert driver to use the mmc_sim interface
rGad494d3b2d4d: rtsx: Update driver version number to 2.1c
rG1e800a593445: rtsx: Do not display pci_read_config() errors during rtsx_init()
rGec1f122b56f9: rtsx: Add CTLFLAG_STATS flag for read and write counters
rG7e5933b33301: rtsx: Prefer __FreeBSD_version over __FreeBSD__
rG8e9740b62e95: rtsx: Convert driver to use the mmc_sim interface
Summary

A lot more generic cam related things are done in mmc_sim so this simplify
the driver a lot. (see https://reviews.freebsd.org/D27486)

Test Plan

add 'options MMCCAM' to kernel config

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 44062
Build 40950: arc lint + arc unit

Event Timeline

hlh_restart.be created this revision.Sep 27 2021, 9:53 AM
Herald added a subscriber: imp. · View Herald TranscriptSep 27 2021, 9:53 AM
hlh_restart.be requested review of this revision.Sep 27 2021, 9:53 AM
Harbormaster completed remote builds in B41781: Diff 95774.Sep 27 2021, 9:54 AM
imp added a comment.Sep 29 2021, 11:59 PM

Generally I think this looks good, modulo the comment about comments on #endif.

sys/dev/rtsx/rtsx.c
657

Here and elsewhere: style(9) says that this is incorrect. The comment at the endif line should match the #if line.

#ifdef COMPAT_43
/* A large region here, or other conditional code. */
#else /* !COMPAT_43 */
/* Or here. */
#endif /* COMPAT_43 */
hlh_restart.be updated this revision to Diff 96004.Sep 30 2021, 6:40 AM
  • Correct style(9): comments on #endif
Harbormaster completed remote builds in B41864: Diff 96004.Sep 30 2021, 6:40 AM
hlh_restart.be marked an inline comment as done.Sep 30 2021, 6:41 AM
hlh_restart.be updated this revision to Diff 101409.Jan 13 2022, 10:27 AM
  • Don't display pci_read_config() errors during rtsx_init()
  • Add CTLFLAG_STATS for read and write counters
Harbormaster completed remote builds in B43898: Diff 101409.Jan 13 2022, 10:27 AM
jkim accepted this revision.Jan 13 2022, 2:32 PM

LGTM

This revision is now accepted and ready to land.Jan 13 2022, 2:32 PM
hlh_restart.be updated this revision to Diff 101838.Jan 24 2022, 9:35 AM
  • Replace FreeBSD by __FreeBSD_version
This revision now requires review to proceed.Jan 24 2022, 9:35 AM
Harbormaster completed remote builds in B44062: Diff 101838.Jan 24 2022, 9:35 AM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 3 2022, 11:44 PM
Closed by commit rG8e9740b62e95: rtsx: Convert driver to use the mmc_sim interface (authored by hlh_restart.be, committed by jkim). · Explain Why
This revision was automatically updated to reflect the committed changes.
jkim added a commit: rG8e9740b62e95: rtsx: Convert driver to use the mmc_sim interface.
jkim added a commit: rG7e5933b33301: rtsx: Prefer __FreeBSD_version over __FreeBSD__.
jkim added a commit: rGec1f122b56f9: rtsx: Add CTLFLAG_STATS flag for read and write counters.
jkim added a commit: rG1e800a593445: rtsx: Do not display pci_read_config() errors during rtsx_init().
jkim added a commit: rGad494d3b2d4d: rtsx: Update driver version number to 2.1c.
mav added a commit: rG545def055b4a: rtsx: Convert driver to use the mmc_sim interface.Feb 23 2022, 1:06 AM
mav added a commit: rG4efab785f6c4: rtsx: Prefer __FreeBSD_version over __FreeBSD__.
mav added a commit: rGa1b4c74dadeb: rtsx: Add CTLFLAG_STATS flag for read and write counters.
mav added a commit: rG23566767c37e: rtsx: Do not display pci_read_config() errors during rtsx_init().
mav added a commit: rG785a5b8d91ab: rtsx: Update driver version number to 2.1c.

Revision Contents
Changeset List

PathSize
sys/
dev/
rtsx/
306 lines
modules/
rtsx/
2 lines

Diff 101838

View Options

sys/dev/rtsx/rtsx.c

Loading...
View Options

sys/modules/rtsx/Makefile

Loading...