Rename META_MODE option to DIRDEPS_BUILD
ClosedPublic
Actions

Authored by sjg on Nov 13 2015, 9:43 PM.

Details

Reviewers

Commits

rS290816: Rename META_MODE option to DIRDEPS_BUILD

Summary

Suggested to rename MK_META_MODE to MK_DIRDEPS_BUILD
so that MK_META_FILES can be renamed to MK_META_MODE
This change if made should be done before stable/11

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 1134
Build 1138: arc lint + arc unit

Event Timeline

sjg updated this revision to Diff 10166.Nov 13 2015, 9:43 PM

sjg retitled this revision from to Rename META_MODE option to DIRDEPS_BUILD.

sjg updated this object.

sjg edited the test plan for this revision. (Show Details)

sjg added a reviewer: bdrewery.

Herald added a subscriber: emaste. · View Herald TranscriptNov 13 2015, 9:43 PM

You'll also need to rename these:

-rw-r--r-- 1 root bryan 104 Aug 4 14:10 tools/build/options/WITH_META_FILES
-rw-r--r-- 1 root bryan 941 Sep 18 15:56 tools/build/options/WITH_META_MODE

And handle these:

tools/build/options/makeman:.Va WITH_META_MODE
tools/build/options/WITH_DIRDEPS_CACHE:.Va WITH_META_MODE .
tools/build/options/WITH_STAGING:.Va WITH_META_MODE .
tools/build/options/WITH_SYSROOT:.Va WITH_META_MODE .

This or WITH_META_BUILD would be nice. I really don't care about the specific name as long as we can differentiate between "meta mode" and "new build". Thanks for doing this!

This revision is now accepted and ready to land.Nov 13 2015, 10:07 PM

In D4153#87243, @bdrewery wrote:

You'll also need to rename these:

-rw-r--r-- 1 root bryan 104 Aug 4 14:10 tools/build/options/WITH_META_FILES
-rw-r--r-- 1 root bryan 941 Sep 18 15:56 tools/build/options/WITH_META_MODE

And handle these:

tools/build/options/makeman:.Va WITH_META_MODE
tools/build/options/WITH_DIRDEPS_CACHE:.Va WITH_META_MODE .
tools/build/options/WITH_STAGING:.Va WITH_META_MODE .
tools/build/options/WITH_SYSROOT:.Va WITH_META_MODE .

Yes, AFAICT the renames have to be done in a couple of steps

In D4153#87262, @sjg wrote:

In D4153#87243, @bdrewery wrote:

You'll also need to rename these:

-rw-r--r-- 1 root bryan 104 Aug 4 14:10 tools/build/options/WITH_META_FILES
-rw-r--r-- 1 root bryan 941 Sep 18 15:56 tools/build/options/WITH_META_MODE

And handle these:

tools/build/options/makeman:.Va WITH_META_MODE
tools/build/options/WITH_DIRDEPS_CACHE:.Va WITH_META_MODE .
tools/build/options/WITH_STAGING:.Va WITH_META_MODE .
tools/build/options/WITH_SYSROOT:.Va WITH_META_MODE .

Yes, AFAICT the renames have to be done in a couple of steps

svn mv should really be enough. You can even edit the new file after a svn mv. One gotcha is that you need to run 'svn up' in the directory before renaming them to avoid a potential hook problem (this is far more common in Ports though and unlikely to hit you here).

define META_COOKIE_TOUCH

This revision now requires review to proceed.Nov 14 2015, 1:07 AM

define META_COOKIE_TOUCH and META_NOPHONY in local.sys.mk

bdrewery accepted this revision.Nov 14 2015, 1:24 AM

bdrewery edited edge metadata.

This revision is now accepted and ready to land.Nov 14 2015, 1:24 AM

bdrewery requested changes to this revision.Nov 14 2015, 1:43 AM

bdrewery edited edge metadata.

bdrewery added inline comments.

share/mk/local.sys.mk
30	we need ${.CURDIR} before ${COOKIE*} to be safe. Some usage has 'cd somedir; ${MAKE}' before the last line, without a sub-shell. Something I encountered in include/Makefile so far.

This revision now requires changes to proceed.Nov 14 2015, 1:43 AM

Closed by commit rS290816: Rename META_MODE option to DIRDEPS_BUILD (authored by sjg). · Explain WhyNov 14 2015, 3:25 AM

This revision was automatically updated to reflect the committed changes.