Page MenuHomeFreeBSD
Differential D33784

fix "set but not used" in the tws driver
ClosedPublic
Actions

Authored by rew on Jan 7 2022, 7:34 PM.
Tags
None
Referenced Files
F155048277: D33784.id101108.diff
Thu, Apr 30, 11:14 PM
F155047801: D33784.id101108.diff
Thu, Apr 30, 11:09 PM
F154959944: D33784.id.diff
Thu, Apr 30, 8:12 AM
Unknown Object (File)
Tue, Apr 28, 4:17 PM
Unknown Object (File)
Tue, Apr 28, 4:10 PM
Unknown Object (File)
Thu, Apr 23, 7:35 AM
Unknown Object (File)
Mon, Apr 20, 5:30 PM
Unknown Object (File)
Fri, Apr 17, 3:50 AM
View All Files
Subscribers
imp

Details

Reviewers
scottl
Commits
rG174d86a01bf6: tws: fix "set but not used" in the tws driver
Summary

With __diagused, these warnings were still emitted since INVARIANTS is
defined but TWS_DEBUG is not.

Not sure if it's better to go with __tws_debug or something like:

#ifdef TWS_DEBUG
        u_int32_t reg;
#endif

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 43772
Build 40660: arc lint + arc unit

Event Timeline

rew created this revision.Jan 7 2022, 7:34 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 7 2022, 7:34 PM
rew requested review of this revision.Jan 7 2022, 7:34 PM
Harbormaster completed remote builds in B43772: Diff 101108.Jan 7 2022, 7:35 PM
rew added a reviewer: scottl.Jan 7 2022, 7:36 PM
imp added a comment.Jan 7 2022, 7:49 PM

__tws_debug is a little shorter, but it's also a bit odd... Since you already have the right place to drop it into tws_services.h, thats likely pushes things in favor of that instead of #ifdef TWS_DEBUG or similar.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2022, 11:32 PM
Closed by commit rG174d86a01bf6: tws: fix "set but not used" in the tws driver (authored by rew). · Explain Why
This revision was automatically updated to reflect the committed changes.
rew added a commit: rG174d86a01bf6: tws: fix "set but not used" in the tws driver.

Revision Contents
Changeset List

PathSize
sys/
dev/
tws/
2 lines
2 lines
2 lines

Diff 101108

View Options

sys/dev/tws/tws.c

Loading...
View Options

sys/dev/tws/tws_hdm.c

Loading...
View Options

sys/dev/tws/tws_services.h

Loading...